Skip to content

lib: replace Float32Array global by the primordials - #31195

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Float32ArrayPrimordials
Closed

lib: replace Float32Array global by the primordials#31195
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Float32ArrayPrimordials

Conversation

@Sebastien-Ahkrin

@Sebastien-AhkrinSebastien-Ahkrin commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

Hello,
For this PR I have added Float32Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
no-restricted-globals:
- name: Float32Arraymessage: "Use `const { Float32Array } = primordials;` instead of the global."

And just add Set.

const{// [...]
Float32Array,}=primordials;

I hope this new PR will help you :x

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. util Issues and PRs related to the built-in util module. labels Jan 5, 2020
@Sebastien-Ahkrin

Sebastien-Ahkrin commented Jan 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Refs: #30697

@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28225/

@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28248/

@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28267/

@Trott

Trott commented Jan 7, 2020

Copy link
Copy Markdown
Member

Landed in 92cef79

Trott pushed a commit that referenced this pull request Jan 7, 2020
@Sebastien-Ahkrin@Trott
lib: replace Float32Array global by the primordials
92cef79
PR-URL: #31195
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@TrottTrott closed this Jan 7, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Sebastien-Ahkrin@MylesBorins
lib: replace Float32Array global by the primordials
f7833ac
PR-URL: #31195
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Sebastien-Ahkrin@codebytere
lib: replace Float32Array global by the primordials
41f0fa7
PR-URL: #31195
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Sebastien-Ahkrin@nodejs-github-bot@Trott@jasnell@targos@cjihrig@gengjiawen@BridgeAR@trivikr