Skip to content

lib: replace Float64Array global by the primordials - #31203

Closed
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Float64ArrayPrimordials
Closed

lib: replace Float64Array global by the primordials#31203
Sebastien-Ahkrin wants to merge 1 commit into
nodejs:masterfrom
Sebastien-Ahkrin:Float64ArrayPrimordials

Conversation

@Sebastien-Ahkrin

@Sebastien-AhkrinSebastien-Ahkrin commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

Hello,
For this PR I have added Float64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
no-restricted-globals:
- name: Float64Array message: "Use `const { Float64Array } = primordials;` instead of the global."

And just add Float64Array.

const{// [...]
Float64Array,}=primordials;

I hope this new PR will help you :x

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 6, 2020
@Sebastien-Ahkrin

Copy link
Copy Markdown
ContributorAuthor

Refs: #30697

@BridgeAR

Copy link
Copy Markdown
Member

This needs a rebase.

@Sebastien-Ahkrin
Sebastien-Ahkrinforce-pushed the Float64ArrayPrimordials branch from 8ed9483 to 21318eaCompareMay 29, 2020 09:47
@BridgeAR
BridgeARforce-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72CompareMay 31, 2020 12:19
@targos

Copy link
Copy Markdown
Member

Superseded by #35397

@targostargos closed this Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Sebastien-Ahkrin@BridgeAR@targos@jasnell@Trott@cjihrig@JungMinu@trivikr@nodejs-github-bot