Skip to content

lib: add Int32Array primordials - #31206

Closed
Sebastien-Ahkrin wants to merge 2 commits into
nodejs:masterfrom
Sebastien-Ahkrin:Int32ArrayPrimordials
Closed

lib: add Int32Array primordials#31206
Sebastien-Ahkrin wants to merge 2 commits into
nodejs:masterfrom
Sebastien-Ahkrin:Int32ArrayPrimordials

Conversation

@Sebastien-Ahkrin

Copy link
Copy Markdown
Contributor

Hello,
For this PR I have added Int32Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
no-restricted-globals:
- name: Int32Array message: "Use `const { Int32Array } = primordials;` instead of the global."

And just add Int32Array .

const{// [...]
Int32Array,}=primordials;

I hope this new PR will help you :x

@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 6, 2020
@Sebastien-Ahkrin

Copy link
Copy Markdown
ContributorAuthor

Refs: #30697

@BridgeAR

Copy link
Copy Markdown
Member

This needs a rebase.

@antsmartian

Copy link
Copy Markdown
Contributor

@Sebastien-Ahkrin Ping. This needs a rebase.

@BridgeAR
BridgeARforce-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72CompareMay 31, 2020 12:19
Comment threadlib/.eslintrc.yaml Outdated
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@targos

Copy link
Copy Markdown
Member

Superseded by #35397

@targostargos closed this Sep 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

utilIssues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@Sebastien-Ahkrin@BridgeAR@antsmartian@targos@jasnell@Trott@cjihrig@patilharshal16@trivikr@nodejs-github-bot