Uh oh!
There was an error while loading. Please reload this page.
docs: fix stream async iterator sample - #31252
Closed
ronag wants to merge 3 commits into
Closed
Conversation
ronagforce-pushed
the
doc-async-iterator-write
branch
2 times, most recently
from
January 7, 2020 21:44
701e364 to
ad5e164Compareronag
commented
Jan 7, 2020
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed
the
doc-async-iterator-write
branch
4 times, most recently
from
January 7, 2020 21:48
02a4a94 to
542711cCompareThe for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: nodejs#31222
ronagforce-pushed
the
doc-async-iterator-write
branch
from
January 7, 2020 21:49
542711c to
a778098Compareronagforce-pushed
the
doc-async-iterator-write
branch
from
January 7, 2020 22:01
cfe161a to
f1d486aCompareronag
commented
Jan 7, 2020
| // Handle backpressure on write(). | ||
| if (!writable.write(chunk)) | ||
| if (!writable.write(chunk)) { | ||
| if (writable.destroyed) return; |
MemberAuthor
There was a problem hiding this comment.
This writable.destroyed check is ugly but I don't see a way around it...
Trott
approved these changes
Jan 10, 2020
jasnell
approved these changes
Jan 10, 2020
Trott pushed a commit
that referenced
this pull request
Jan 10, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Jan 10, 2020
Member
Landed in e468759...5f76f76. Thanks for using |
MylesBorins pushed a commit
that referenced
this pull request
Jan 16, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 14, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Mar 17, 2020
The for await loop into writable loop could cause an unhandled exception in the case where we are waiting for data from the async iterable and this no `'error'` handler is registered on the writable. Fixes: #31222 PR-URL: #31252 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The for await loop into writable could cause an unhandled exception
in the case where we are waiting for data from the async iterable and
there is no
'error'handler registered on the writable.Fixes: #31222
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes