Skip to content

doc: update README to make Node.js description clearer - #31266

Closed
carterbancroft wants to merge 1 commit into
nodejs:masterfrom
carterbancroft:update-node-description
Closed

doc: update README to make Node.js description clearer#31266
carterbancroft wants to merge 1 commit into
nodejs:masterfrom
carterbancroft:update-node-description

Conversation

@carterbancroft

@carterbancroftcarterbancroft commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

Fixes: #24872

This PR updates the README's original description:

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine.

To:

Node.js is an open-source, cross-platform, JavaScript runtime environment. It executes JavaScript code outside of a browser

Based on the two sentence suggestion from the issue discussion.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 9, 2020
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020
@Trott

Trott commented Jan 11, 2020

Copy link
Copy Markdown
Member

Landed in 6d44308

@TrottTrott closed this Jan 11, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 11, 2020
@carterbancroft@Trott
doc: update README to make Node.js description clearer
6d44308
Fixes: nodejs#24872
PR-URL: nodejs#31266
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@carterbancroft@MylesBorins
doc: update README to make Node.js description clearer
deff600
Fixes: #24872
PR-URL: #31266
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@carterbancroft@codebytere
doc: update README to make Node.js description clearer
07c3b6d
Fixes: #24872
PR-URL: #31266
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@carterbancroft@codebytere
doc: update README to make Node.js description clearer
cb40a1a
Fixes: #24872
PR-URL: #31266
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need change in the read me file

7 participants

@carterbancroft@Trott@lpinca@devnexen@gireeshpunathil@BridgeAR@nodejs-github-bot