Skip to content

doc: improve doc v8.getHeapSpaceStatistics() - #31274

Closed
dev-script wants to merge 1 commit into
nodejs:masterfrom
dev-script:doc/v8_module
Closed

doc: improve doc v8.getHeapSpaceStatistics()#31274
dev-script wants to merge 1 commit into
nodejs:masterfrom
dev-script:doc/v8_module

Conversation

@dev-script

Copy link
Copy Markdown
Contributor

'GetHeapSpaceStatistics' Link replaced in v8 getHeapSpaceStatistics
function because it was showing 404 page not found.

Fixes: #31181

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

'GetHeapSpaceStatistics' Link replaced in v8 getHeapSpaceStatistics
function because it was showing 404 page not found.
Fixes: #31181
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 9, 2020
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2020

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'd guess it's only a matter of time before this 404s again. But until then!

Trott pushed a commit that referenced this pull request Jan 11, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.
Fixes: #31181
PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Copy link
Copy Markdown
Member

Landed in 2a94c9f

@TrottTrott closed this Jan 11, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.
Fixes: #31181
PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.
Fixes: #31181
PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.
Fixes: #31181
PR-URL: #31274
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v8.getHeapSpaceStatistics() link to GetHeapSpaceStatistics() is broken

11 participants

@dev-script@Trott@jasnell@addaleax@lpinca@cjihrig@devnexen@richardlau@gireeshpunathil@BridgeAR@nodejs-github-bot