module: expose exports conditions to loaders by hybrist · Pull Request #31303 · nodejs/node

hybrist · 2020-01-10T18:28:12Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

hybrist · 2020-01-10T18:28:26Z

/cc @nodejs/modules-active-members

guybedford · 2020-01-11T07:00:00Z

Nice work, this approach seems great!

hybrist · 2020-02-10T18:19:03Z

Cleaned up and marking as ready for review. I updated the implementation to use a std::set instead of V8::Set. In the process the conditions cache got moved into C++, JS only creates the key (\0-separated condition names).

guybedford

Seems like a nice approach.

hybrist · 2020-03-02T18:07:28Z

Ping @nodejs/modules-active-members, this is still lacking some reviews/approvals before we can land it. Adding it to the agenda in case it's still open by our next meeting. :)

bmeck

I really like this PR! This falls into some things we are starting to see from the community about custom conditions like https://twitter.com/sebmarkbage/status/1234223477424447488 .

guybedford

Would be great to see this moving forward :)

guybedford

Looks good, thanks.

nodejs-github-bot · 2020-03-29T21:52:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30219/ (:heavy_check_mark:)

nodejs-github-bot · 2020-03-31T16:35:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30286/

hybrist · 2020-03-31T17:16:19Z

There's one C++ test that seems to fail on linuxone. I look into it briefly but I don't see a clear reason why it would fail (or what the failure really means). I'm surprised that this PR would affect low-level worker interactions but can't rule it out.

addaleax · 2020-04-02T16:11:20Z

@jkrems See #32563 – I just landed a fix for that. :) Is this still ready to land, apart from waiting for a green CI?

nodejs-github-bot · 2020-04-02T16:12:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30370/

hybrist · 2020-04-02T16:12:52Z

Is this still ready to land, apart from waiting for a green CI?

Yes! This should be good to go, assuming CI comes back green.

(And thanks for being on top of these build failures, much appreciated. :))

nodejs-github-bot · 2020-04-02T23:08:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30394/

PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

addaleax · 2020-04-02T23:29:50Z

Landed in 9129ab1

PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

PR-URL: nodejs#31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jan 10, 2020

hybrist commented Jan 10, 2020
View reviewed changes

Comment threadlib/internal/modules/esm/resolve.js Outdated

addaleax reviewed Jan 11, 2020
View reviewed changes

GeoffreyBooth reviewed Jan 11, 2020
View reviewed changes

Comment threadtest/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated

sparebytes mentioned this pull request Jan 21, 2020
[Case Study] Exports Support yarnpkg/berry#650
Closed
1 task

hybrist force-pushed the loader-conditions branch 9 times, most recently from d05c96e to 66ebe58Compare February 10, 2020 18:13

hybrist marked this pull request as ready for review February 10, 2020 18:18

guybedford reviewed Feb 10, 2020
View reviewed changes

Comment threadsrc/module_wrap.cc Outdated
Comment threadtest/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated

hybrist force-pushed the loader-conditions branch from 66ebe58 to 7c15d59Compare March 2, 2020 18:02

hybrist added the modules-agenda Issues and PRs to discuss during the meetings of the Modules team. label Mar 2, 2020

bmeck approved these changes Mar 2, 2020
View reviewed changes

This comment has been minimized.
Sign in to view

hybrist added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020

GeoffreyBooth reviewed Mar 2, 2020
View reviewed changes

Comment threadtest/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated

This comment has been minimized.
Sign in to view

guybedford approved these changes Mar 3, 2020
View reviewed changes

Comment threadsrc/module_wrap.cc Outdated
Comment threadtest/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated

bmeck reviewed Mar 3, 2020
View reviewed changes

Comment threaddoc/api/esm.md Outdated

guybedford approved these changes Mar 17, 2020
View reviewed changes

Comment threaddoc/api/esm.md Outdated

hybrist force-pushed the loader-conditions branch from 8703335 to 19b2f4fCompare March 17, 2020 17:42

guybedford approved these changes Mar 23, 2020
View reviewed changes

Comment threadlib/internal/modules/esm/resolve.js Outdated
Comment threadlib/internal/modules/esm/resolve.js Outdated

hybrist force-pushed the loader-conditions branch from 19b2f4f to a14ba1eCompare March 30, 2020 16:16

This comment has been minimized.
Sign in to view

hybrist force-pushed the loader-conditions branch from a14ba1e to 8108485Compare March 30, 2020 16:31

himself65 reviewed Mar 30, 2020
View reviewed changes

Comment threadlib/internal/modules/esm/loader.js Outdated

hybrist force-pushed the loader-conditions branch from 8108485 to 2267d17Compare March 30, 2020 17:13

This comment has been minimized.
Sign in to view

module: expose exports conditions to loaders
1549bc4

hybrist force-pushed the loader-conditions branch from 2267d17 to 1549bc4Compare March 31, 2020 16:34

addaleax closed this Apr 2, 2020

targos pushed a commit that referenced this pull request Apr 12, 2020
module: expose exports conditions to loaders
537d2c1
PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020

targos pushed a commit that referenced this pull request Apr 28, 2020
module: expose exports conditions to loaders
b62910c
PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged

Uh oh!

Uh oh!

Conversation

hybrist commented Jan 10, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

hybrist commented Jan 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guybedford commented Jan 11, 2020

Uh oh!

Uh oh!

hybrist commented Feb 10, 2020

Uh oh!

guybedford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hybrist commented Mar 2, 2020

Uh oh!

bmeck left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

guybedford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guybedford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 29, 2020• edited by addaleax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 31, 2020

Uh oh!

hybrist commented Mar 31, 2020

Uh oh!

addaleax commented Apr 2, 2020

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

hybrist commented Apr 2, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

addaleax commented Apr 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

hybrist commented Jan 10, 2020•
edited
Loading

nodejs-github-bot commented Mar 29, 2020•
edited by addaleax
Loading

hybrist commented Apr 2, 2020•
edited
Loading