Skip to content

stream: async iterator improvements - #31316

Closed
ronag wants to merge 5 commits into
nodejs:masterfrom
nxtedition:stream-async-iterator
Closed

stream: async iterator improvements#31316
ronag wants to merge 5 commits into
nodejs:masterfrom
nxtedition:stream-async-iterator

Conversation

@ronag

@ronagronag commented Jan 11, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Includes a few different fixes separated into commits:

  • Adds support to create async iterators from v1 streams.
  • Normalize destroying non conforming streams.
  • Implement throw on the iterator.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag

ronag commented Jan 11, 2020

Copy link
Copy Markdown
MemberAuthor

ping @addaleax

ronag
ronag commented Jan 11, 2020
View reviewed changes
Comment threadlib/internal/streams/async_iterator.js Outdated
@ronag
ronagforce-pushed the stream-async-iterator branch 2 times, most recently from f87b6e6 to 7558199CompareJanuary 11, 2020 16:27
@ronagronag changed the title stream: add async iterator support for v1 streamsstream: async iterator fixesJan 11, 2020
@ronag
ronagforce-pushed the stream-async-iterator branch 6 times, most recently from a4f1b62 to 00d40b3CompareJanuary 11, 2020 17:30
@ronagronag changed the title stream: async iterator fixesstream: async iterator improvementsJan 11, 2020
@ronag
ronagforce-pushed the stream-async-iterator branch from 00d40b3 to d8dbe8aCompareJanuary 11, 2020 18:07
mcollina
mcollina reviewed Jan 11, 2020
View reviewed changes
Comment threadlib/internal/streams/async_iterator.js Outdated
Comment threadtest/parallel/test-stream-readable-async-iterators.js Outdated
@ronag
ronagforce-pushed the stream-async-iterator branch 2 times, most recently from 1e6c55e to f1c4e5aCompareJanuary 12, 2020 00:06
mcollina
mcollina reviewed Jan 12, 2020
View reviewed changes
Comment threadtest/parallel/test-stream-readable-async-iterators.js Outdated
mcollina
mcollina reviewed Jan 12, 2020
View reviewed changes
Comment threadlib/internal/streams/legacy.js Outdated
@ronag
ronagforce-pushed the stream-async-iterator branch 2 times, most recently from 5c034b4 to 54a560bCompareJanuary 12, 2020 11:44
@nodejs-github-bot

nodejs-github-bot commented Jan 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28400/

mcollina
mcollina approved these changes Jan 12, 2020
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BridgeARBridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem. labels Jan 12, 2020
reklatsmasters
reklatsmasters reviewed Jan 12, 2020
View reviewed changes
Comment threadlib/internal/streams/async_iterator.js Outdated
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ronagronag closed this Jan 26, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@ronag@codebytere
stream: add async iterator support for v1 streams
20d0a0e
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@ronag@codebytere
stream: normalize async iterator stream destroy
5a95fa4
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@ronag@codebytere
stream: implement throw for async iterator
3046648
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
@codebytere

codebytere commented Feb 29, 2020

Copy link
Copy Markdown
Member

@ronag the last two commits in this PR need manual backports

@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2020
Closed
7 tasks
@ronagronag mentioned this pull request Mar 10, 2020
Closed
4 tasks
ronag added a commit to nxtedition/node that referenced this pull request Mar 10, 2020
@ronag
stream: simplify pipeline
0abd4f0
PR-URL: nodejs#31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: nodejs#32174
ronag added a commit to nxtedition/node that referenced this pull request Mar 10, 2020
@ronag
stream: re-use legacy destroyer
2578e5d
PR-URL: nodejs#31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: nodejs#32174
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@ronag@MylesBorins
stream: simplify pipeline
7ce1cc9
Backport-PR-URL: #32174
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@ronag@MylesBorins
stream: re-use legacy destroyer
4b04bf8
Backport-PR-URL: #32174
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 10, 2020
Merged
@codebytere

codebytere commented Mar 15, 2020

Copy link
Copy Markdown
Member

@ronag should this go to v12.x, and if yes, can you open a manual backport? Given the recent issues on v13.x i'd like to play it safe so feel free to update the label to don't-land.

@targostargos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020
This was referenced Jun 16, 2020
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@JungMinuJungMinuJungMinu approved these changes
+1 more reviewer
@reklatsmastersreklatsmastersreklatsmasters left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@ronag@nodejs-github-bot@codecov-io@Trott@codebytere@mcollina@addaleax@reklatsmasters@JungMinu@MylesBorins@targos@BridgeAR