Uh oh!
There was an error while loading. Please reload this page.
util: improve unicode support - #31319
Closed
BridgeAR wants to merge 3 commits into
Closed
Conversation
BridgeARforce-pushed
the
2020-01-11-util-better-unicode-support
branch
from
January 11, 2020 22:36
81735c6 to
02515e8Compare
This comment has been minimized.
This comment has been minimized.
BridgeARforce-pushed
the
2020-01-11-util-better-unicode-support
branch
from
January 12, 2020 02:30
02515e8 to
80fe23bCompare
This comment has been minimized.
This comment has been minimized.
BridgeARforce-pushed
the
2020-01-11-util-better-unicode-support
branch
from
January 12, 2020 23:38
da70f98 to
fc7f090CompareTrott
commented
Jan 13, 2020
Member
I'm not sure who to ping for a review. @srl295 maybe? |
jasnell
approved these changes
Jan 13, 2020
srl295
approved these changes
Jan 13, 2020
srl295
left a comment
Member
There was a problem hiding this comment.
LGTM. Could optimize the existing code, but generally LGTM.
Member
There was a problem hiding this comment.
So this might be doable as a regex… it could be compiled as a regex, i don't think there's an East Asian Width property available in regex.
MemberAuthor
There was a problem hiding this comment.
This could definitely be a regular expression. I guess it's slower that way but I did not check. I'll have a look soon.
Member
There was a problem hiding this comment.
ICU4C also has API to get the East Asian Width.
MemberAuthor
There was a problem hiding this comment.
Yes, we use that in case Node.js is build with ICU but this is the fallback code.
Trott
approved these changes
Jan 14, 2020
JungMinu
approved these changes
Jan 16, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ).
BridgeARforce-pushed
the
2020-01-11-util-better-unicode-support
branch
from
January 17, 2020 08:51
fc7f090 to
1b9547fComparenodejs-github-bot
commented
Jan 17, 2020
Collaborator
Trott
commented
Jan 18, 2020
Member
Relevant test failures in the no-intl host on CI? |
nodejs-github-bot
commented
Jan 20, 2020
Collaborator
BridgeAR added a commit
that referenced
this pull request
Jan 22, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: #31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
BridgeAR
commented
Jan 22, 2020
MemberAuthor
Landed in 8fb5fe2 🎉 |
codebytere pushed a commit
that referenced
this pull request
Feb 17, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: #31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
codebytere
commented
Mar 15, 2020
Member
@BridgeAR if this should go back to |
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: nodejs#31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
The array grouping function relies on the width of the characters. It was not calculated correct so far, since it used the string length instead. This improves the unicode output by calculating the mono-spaced font width (other fonts might differ). PR-URL: #31319 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array grouping function relies on the width of the characters.
It was not calculated correct so far, since it used the string
length instead.
This improves the unicode output by calculating the mono-spaced
font width (other fonts might differ).
I had to move some functions. Otherwise we'd have to load the utils functions by default and that did not seem necessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes