Skip to content

deps: upgrade to libuv 1.34.1 - #31332

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:libuv
Closed

deps: upgrade to libuv 1.34.1#31332
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:libuv

Conversation

@cjihrig

Copy link
Copy Markdown
Contributor

Notable changes:

  • uv_fs_copyfile() now supports CIFS share destinations.
  • isatty() now works on IBMi
  • TTYs are opened with the O_NOCTTY flag.

Fixes: #31170

Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: nodejs#31170
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels Jan 12, 2020

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

nodejs-github-bot commented Jan 14, 2020

Copy link
Copy Markdown
Collaborator

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott

Copy link
Copy Markdown
Member

Landed in 216e423

@TrottTrott closed this Jan 15, 2020
Trott pushed a commit that referenced this pull request Jan 15, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: #31170
PR-URL: #31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig
cjihrig deleted the libuv branch January 15, 2020 01:11
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: #31170
PR-URL: #31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebyterecodebytere mentioned this pull request Jan 16, 2020
codebytere added a commit that referenced this pull request Jan 20, 2020
Notable changes:
* deps:
* upgrade to libuv 1.34.1 (cjihrig) #31332
* upgrade npm to 6.13.6 (Ruy Adorno) #31304
* doc:
* add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
* module
* add API for interacting with source maps (bcoe) #31132
* loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
* logical conditional exports ordering (Guy Bedford) #31008
* unflag conditional exports (Guy Bedford) #31001
* process:
* allow monitoring uncaughtException (Gerhard Stoebich) #31257
PR-URL: #31382
codebytere added a commit that referenced this pull request Jan 21, 2020
Notable changes:
* deps:
* upgrade to libuv 1.34.1 (cjihrig) #31332
* upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
* add API for interacting with source maps (bcoe) #31132
* loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
* logical conditional exports ordering (Guy Bedford) #31008
* unflag conditional exports (Guy Bedford) #31001
* process:
* allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
* [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306
PR-URL: #31382
codebytere added a commit that referenced this pull request Jan 21, 2020
Notable changes:
* deps:
* upgrade to libuv 1.34.1 (cjihrig) #31332
* upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
* add API for interacting with source maps (bcoe) #31132
* loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
* logical conditional exports ordering (Guy Bedford) #31008
* unflag conditional exports (Guy Bedford) #31001
* process:
* allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
* [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306
PR-URL: #31382
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Feb 26, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: nodejs#31170
PR-URL: nodejs#31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 2, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: #31170
PR-URL: #31332
Backport-PR-URL: #31969
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Mar 12, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: #31170
PR-URL: #31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: #31170
PR-URL: #31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
zcbenz pushed a commit to yue/node that referenced this pull request Apr 3, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: nodejs/node#31170
PR-URL: nodejs/node#31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
zcbenz pushed a commit to yue/node that referenced this pull request Apr 3, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: nodejs/node#31170
PR-URL: nodejs/node#31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
zcbenz pushed a commit to yue/node that referenced this pull request Apr 3, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: nodejs/node#31170
PR-URL: nodejs/node#31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
zcbenz pushed a commit to yue/node that referenced this pull request Apr 3, 2020
Notable changes:
- uv_fs_copyfile() now supports CIFS share destinations.
- isatty() now works on IBMi
- TTYs are opened with the O_NOCTTY flag.
Fixes: nodejs/node#31170
PR-URL: nodejs/node#31332
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.libuvIssues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.copyFile fails with "EPERM" for CIFS destination

9 participants

@cjihrig@nodejs-github-bot@Trott@bnoordhuis@gengjiawen@devnexen@richardlau@BridgeAR@trivikr