fs: add statfs to fs

[SheikhSajid]

Add support for statfs system call to the fs module using
uv_fs_statfs() function from libuv.

Refs: #10745

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

Thanks, nice work!

This looks good with the spare field(s) removed.

[bnoordhuis]

Thanks, LGTM but as mentioned, all references to the spare fields can be dropped.

[cjihrig]

LGTM with all of the spares removed.

[Trott]

@SheikhSajid I only meant to alphabetize the documentation headers/entries, not the order of properties in the object output in the console. Sorry that I wasn't clear about that!

In other words:

### foo

should appear after:

### bar

but this is OK, and should be retained if it's what the order of the actual output will be:

```console{ foo: 'first', bar: 'second'}```

[SheikhSajid]

@SheikhSajid I only meant to alphabetize the documentation headers/entries, not the order of properties in the object output in the console. Sorry that I wasn't clear about that!

In other words:

### foo

should appear after:

### bar

but this is OK, and should be retained if it's what the order of the actual output will be:

```console
{
foo: 'first',
bar: 'second'
}

Fixed

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/28466/

[Trott]

I'm sorry to report that the test for this new feature fails on Windows in our CI:

13:24:34 not ok 190 parallel/test-fs-statfs13:24:34 ---13:24:34 duration_ms: 0.19813:24:34 severity: fail13:24:34 exitcode: 113:24:34 stack: |-13:24:34 internal/fs/utils.js:25913:24:34 throw err;13:24:34 ^13:24:34 13:24:34 Error: ENOENT: no such file or directory, statfs 'C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-fs-statfs.js'13:24:34 at Object.statfsSync (fs.js:976:3)13:24:34 at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-fs-statfs.js:39:24)13:24:34 at Module._compile (internal/modules/cjs/loader.js:1208:30)13:24:34 at Object.Module._extensions..js (internal/modules/cjs/loader.js:1228:10)13:24:34 at Module.load (internal/modules/cjs/loader.js:1057:32)13:24:34 at Function.Module._load (internal/modules/cjs/loader.js:952:14)13:24:34 at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)13:24:34 at internal/main/run_main_module.js:17:47 {13:24:34 errno: -4058,13:24:34 syscall: 'statfs',13:24:34 code: 'ENOENT',13:24:34 path: 'C:\\workspace\\node-test-binary-windows-js-suites\\node\\test\\parallel\\test-fs-statfs.js'13:24:34 }13:24:34 ...

[BridgeAR]

Ping @SheikhSajid

[SheikhSajid]

Seems like a libuv issue on Windows. I compiled libuv on Windows and uv_fs_statfs is returning errors whenever a path to a file is passed to it. Folders work fine.

[SheikhSajid]

I will try to look into why this is happening.

[jasnell]

@SheikhSajid ... looks like this has stalled out and needs a rebase. Do you intend on moving this forward?

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

[cybershape]

it looks like everything is ready, should anyone make this happen will be super.