Uh oh!
There was an error while loading. Please reload this page.
errors: make use of "cannot" consistent - #31420
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Jan 20, 2020
tniessen
commented
Jan 20, 2020
MemberAuthor
Not sure if error message changes are semver-minor or not...? |
cjihrig
commented
Jan 20, 2020
Contributor
As long as the error code doesn't change, the current policy is for error message changes to be semver patch. |
addaleax
approved these changes
Jan 20, 2020
This comment has been minimized.
This comment has been minimized.
tniessen
commented
Jan 20, 2020
MemberAuthor
Only failures are infrastructure failures. |
sam-github
approved these changes
Jan 20, 2020
BridgeAR
approved these changes
Jan 20, 2020
nodejs-github-bot
commented
Jan 20, 2020
Collaborator
targos
approved these changes
Jan 21, 2020
Trott
approved these changes
Jan 22, 2020
tniessenforce-pushed
the
errors-make-cannot-consistent
branch
from
January 22, 2020 19:51
b5d9f15 to
a19b777Comparetniessen
commented
Jan 22, 2020
MemberAuthor
Had to rebase and adapt a test case that was added yesterday (#31178). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jan 22, 2020
Collaborator
tniessen added a commit
that referenced
this pull request
Jan 23, 2020
PR-URL: #31420 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
tniessen
commented
Jan 23, 2020
MemberAuthor
Landed in 9f22fda, thanks for reviewing! |
codebytere pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31420 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31420 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31420 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We frequently use the word "cannot" in error messages, this is the only occurrence of "can not". I am not a native English speaker, but according to various resources, the former should generally be preferred over the latter, and is probably what native speakers would expect.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes