Uh oh!
There was an error while loading. Please reload this page.
tls: simplify errors using ThrowCryptoError - #31436
Closed
tniessen wants to merge 2 commits into
Closed
Conversation
addaleax
approved these changes
Jan 21, 2020
cjihrig
approved these changes
Jan 21, 2020
devnexen
approved these changes
Jan 21, 2020
nodejs-github-bot
commented
Jan 21, 2020
Collaborator
bnoordhuis
approved these changes
Jan 22, 2020
Trott
approved these changes
Jan 23, 2020
MemberAuthor
Landed in ab6ab9c (was Had to force-push master because the commit message didn't match the PR title anymore, sorry about that. |
tniessen added a commit
that referenced
this pull request
Jan 23, 2020
PR-URL: #31436 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31436 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31436 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31436 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to a default message if
err == 0is already implemented inThrowCryptoError. This should not cause any observable change in behavior.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes