Uh oh!
There was an error while loading. Please reload this page.
test: fix invalid variable name - #3150
Closed
thefourtheye wants to merge 1 commit into
Closed
Conversation
The variable `er` is not declared at all. So if EPERM error is ever raised then the `er` will throw `ReferenceError` and the code will break.
mscdex
commented
Oct 1, 2015
Contributor
LGTM |
thefourtheye added a commit
that referenced
this pull request
Oct 1, 2015
The variable `er` is not declared at all. So if EPERM error is ever raised then the `er` will throw `ReferenceError` and the code will break. PR-URL: #3150 Reviewed-By: Brian White <mscdex@mscdex.net>
jbergstroem
commented
Oct 1, 2015
Member
LGTM |
thefourtheye
commented
Oct 1, 2015
ContributorAuthor
Pushing this as it is a trivial change and it landed at 6be2a59 |
thefourtheye added a commit
that referenced
this pull request
Oct 2, 2015
The variable `er` is not declared at all. So if EPERM error is ever raised then the `er` will throw `ReferenceError` and the code will break. PR-URL: #3150 Reviewed-By: Brian White <mscdex@mscdex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
eris not declared at all. So if EPERM error is everraised then the
erwill throwReferenceErrorand the code willbreak.
CI Run: https://ci.nodejs.org/job/node-test-pull-request/408/