Uh oh!
There was an error while loading. Please reload this page.
Update maintaining-V8.md - #31503
Closed
kzs0 wants to merge 2 commits into
Closed
Conversation
Updated to conform to style guide.
Trott
commented
Jan 26, 2020
Member
We don't specify how to do capitalization in headers in the style guide, do we? |
kzs0
commented
Jan 26, 2020
ContributorAuthor
No I suppose not, but this would keep the file internally consistent in its capitalization. |
Trott
commented
Jan 26, 2020
Member
In that case, can you update line 320 as well? |
Trott
approved these changes
Jan 26, 2020
Trott
approved these changes
Jan 27, 2020
addaleax
approved these changes
Jan 28, 2020
addaleax
commented
Jan 28, 2020
Member
Landed in 3d456b1 🎉 |
addaleax pushed a commit
that referenced
this pull request
Jan 28, 2020
Updated to conform to style guide. PR-URL: #31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit
that referenced
this pull request
Feb 17, 2020
Updated to conform to style guide. PR-URL: #31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 16, 2020
Updated to conform to style guide. PR-URL: #31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit
that referenced
this pull request
Mar 17, 2020
Updated to conform to style guide. PR-URL: #31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 23, 2020
Updated to conform to style guide. PR-URL: #31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit
that referenced
this pull request
Mar 30, 2020
Updated to conform to style guide. PR-URL: #31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to conform to style guide.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes