Skip to content

build: support android build on ndk version equal or above 23(Android… - #31521

Closed
forfun414 wants to merge 7 commits into
nodejs:masterfrom
forfun414:support-android
Closed

build: support android build on ndk version equal or above 23(Android…#31521
forfun414 wants to merge 7 commits into
nodejs:masterfrom
forfun414:support-android

Conversation

@forfun414

@forfun414forfun414 commented Jan 26, 2020

Copy link
Copy Markdown
Contributor

… 6.0)

change scripts and sources for android build, don't need standalone toolchain a
fter ndk 19, and use clang as default android target compiler.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [x ] commit message follows commit guidelines

@forfun414
build: support android build on ndk version equal or above 23(Android…
2981fb4
… 6.0)
change scripts and sources for android build, don't need standalone toolchain a\
fter ndk 19, and use clang as default android target compiler.
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. libuv Issues and PRs related to the libuv dependency or the uv binding. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory. labels Jan 26, 2020
mscdex
mscdex reviewed Jan 26, 2020
View reviewed changes
Comment threaddeps/cares/config/android/ares_config.h Outdated
devnexen
devnexen previously approved these changes Jan 27, 2020
View reviewed changes
Comment threaddeps/openssl/openssl-cl_no_asm.gypi Outdated
@TrottTrott added the android Issues and PRs related to the android platform. label Jan 28, 2020
@Trott

Trott commented Jan 28, 2020

Copy link
Copy Markdown
Member

/ping @gcampax Any chance you would be able to verify these changes?

@forfun414
build: support android build on ndk version equal or above 23(Android…
93d6de1
… 6.0)
merge linux and android into one conditon
@forfun414
build: support android build on ndk version equal or above 23(Android…
0dac234
… 6.0)
merge linux and android into one conditon and support arch aarch64 compile
richardlau
richardlau reviewed Jan 29, 2020
View reviewed changes
Comment threadandroid-configure Outdated
@forfun414
build: support android build on ndk version equal or above 23(Android…
fdd4cfc
… 6.0)
fix gcc version checking failed conditons, like gcc 8.1
@gcampax

gcampax commented Feb 14, 2020

Copy link
Copy Markdown
Contributor

I build-tested this locally and it seems to work. One caveat is that I don't use the android-configure script so I didn't test that.
Also, I realized I had the same patch for c-ares locally, so that's good for sure.

@Trott

Trott commented Feb 18, 2020

Copy link
Copy Markdown
Member

@nodejs/collaborators Any folks with sufficient Android familiarity to approve this? Maybe some folks to at least weigh in on the GYP changes? I'd hate to have to chose between rubber-stamping this or not including it.....

cclauss
cclauss requested changes Feb 18, 2020
View reviewed changes
Comment threaddeps/openssl/openssl_no_asm.gypi Outdated
@forfun414
build: support android build on ndk version equal or above 23(Android…
a4aedd4
… 6.0)
change syntax for android and linux case
@nodejs-github-bot

nodejs-github-bot commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29696/

@Trott

Trott commented Mar 10, 2020

Copy link
Copy Markdown
Member

Would any of these files in deps need to be upstreamed first or are they all Node.js additions? Not sure who to ping for that question but let's go with @nodejs/build-files

@richardlau

richardlau commented Mar 10, 2020

Copy link
Copy Markdown
Member

Would any of these files in deps need to be upstreamed first or are they all Node.js additions? Not sure who to ping for that question but let's go with @nodejs/build-files

With the exception of the deps/uv files those are all Node.js additions. libuv is in the process of dropping gyp support (libuv/libuv#2682) so we'll end up owning the gyp files here in nodejs/node (like we have done with the gyp files for V8).

cc @nodejs/libuv

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29716/

@Trott

Trott commented Mar 11, 2020

Copy link
Copy Markdown
Member

This has one approval, has been open for more than seven days, and has a passing CI. This can land. Would be nice to get some more eyes on it. While it's a change for android, it touches a few files that are used by everyone.....

addaleax pushed a commit that referenced this pull request Mar 11, 2020
@forfun414@addaleax
build: support android build on ndk version equal or above 23
50317c3
change scripts and sources for android build, don't need standalone
toolchain after ndk 19, and use clang as default android target
compiler.
PR-URL: #31521
Reviewed-By: Christian Clauss <cclauss@me.com>
@addaleax

addaleax commented Mar 11, 2020

Copy link
Copy Markdown
Member

Landed in 50317c3

MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@forfun414@MylesBorins
build: support android build on ndk version equal or above 23
d66daa5
change scripts and sources for android build, don't need standalone
toolchain after ndk 19, and use clang as default android target
compiler.
PR-URL: #31521
Reviewed-By: Christian Clauss <cclauss@me.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 12, 2020
Merged
gcampax pushed a commit to stanford-oval/node that referenced this pull request Apr 5, 2020
@forfun414@gcampax
build: support android build on ndk version equal or above 23
09b1f46
change scripts and sources for android build, don't need standalone
toolchain after ndk 19, and use clang as default android target
compiler.
PR-URL: nodejs#31521
Reviewed-By: Christian Clauss <cclauss@me.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@forfun414@targos
build: support android build on ndk version equal or above 23
e655869
change scripts and sources for android build, don't need standalone
toolchain after ndk 19, and use clang as default android target
compiler.
PR-URL: #31521
Reviewed-By: Christian Clauss <cclauss@me.com>
@targostargos mentioned this pull request Apr 22, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes
@richardlaurichardlaurichardlau left review comments
+2 more reviewers
@mscdexmscdexmscdex left review comments
@devnexendevnexendevnexen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

androidIssues and PRs related to the android platform.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.libuvIssues and PRs related to the libuv dependency or the uv binding.opensslIssues and PRs related to the OpenSSL dependency.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@forfun414@Trott@gcampax@nodejs-github-bot@richardlau@addaleax@mscdex@cclauss@devnexen