Skip to content

src: fix minor typo in base_object.h - #31535

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:das-gc
Closed

src: fix minor typo in base_object.h#31535
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:das-gc

Conversation

@danbev

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 27, 2020
@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbevdanbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2020
danbev added a commit that referenced this pull request Jan 30, 2020
PR-URL: #31535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in d227d22.

@danbevdanbev closed this Jan 30, 2020
@danbev
danbev deleted the das-gc branch January 30, 2020 11:26
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
targos pushed a commit that referenced this pull request Apr 18, 2020
PR-URL: #31535
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Apr 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@danbev@jasnell@Trott@addaleax@cjihrig@devnexen@nodejs-github-bot