Skip to content

doc: list largepage values in --help - #31537

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:doc
Feb 1, 2020
Merged

doc: list largepage values in --help#31537
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:doc

Conversation

@cjihrig

Copy link
Copy Markdown
Contributor

This commit adds the supported --use-largepages values to the --help menu.

Fixes: #31533

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 27, 2020
Comment threadsrc/node_options.cc Outdated
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2020

Copy link
Copy Markdown
Collaborator

This commit adds the supported --use-largepages values to
the --help menu.
PR-URL: nodejs#31537Fixes: nodejs#31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig
cjihrig merged commit 2272489 into nodejs:masterFeb 1, 2020
@cjihrig
cjihrig deleted the doc branch February 1, 2020 05:25
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This commit adds the supported --use-largepages values to
the --help menu.
PR-URL: #31537Fixes: #31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
@targos

Copy link
Copy Markdown
Member

Depends on large pages changes to land on v12.x

targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
This commit adds the supported --use-largepages values to
the --help menu.
PR-URL: nodejs#31537Fixes: nodejs#31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
This commit adds the supported --use-largepages values to
the --help menu.
PR-URL: #31537Fixes: #31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request May 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node --help doesn't list values for --use-largepages=...

9 participants

@cjihrig@nodejs-github-bot@targos@bnoordhuis@jasnell@Trott@addaleax@devnexen@lundibundi