Skip to content

docs: update collaborator guide with citgm instructions - #31549

Closed
ronag wants to merge 6 commits into
nodejs:masterfrom
nxtedition:doc-citgm
Closed

docs: update collaborator guide with citgm instructions#31549
ronag wants to merge 6 commits into
nodejs:masterfrom
nxtedition:doc-citgm

Conversation

@ronag

@ronagronag commented Jan 28, 2020

Copy link
Copy Markdown
Member

Adds more information about running CITGM jobs.

Note, not sure what commit prefix to use in the root?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag
ronag requested a review from TrottJanuary 28, 2020 13:17
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 28, 2020
@ronag

ronag commented Jan 28, 2020

Copy link
Copy Markdown
MemberAuthor

@nodejs/documentation

addaleax
addaleax approved these changes Jan 28, 2020
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ronag

ronag commented Jan 28, 2020

Copy link
Copy Markdown
MemberAuthor

credit to @Trott :)

richardlau
richardlau reviewed Jan 28, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
richardlau
richardlau reviewed Jan 28, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
richardlau
richardlau approved these changes Jan 28, 2020
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM if you add the new section to the TOC.

@richardlau

richardlau commented Jan 28, 2020

Copy link
Copy Markdown
Member

(And for whoever lands this the subsystem is usually doc (without the s). Travis CI does flag this (on the "Checks" tab and in Travis itself) but we marked the job as allowed to fail so it won't show up on this tab. git node land should also complain.)

@ronagronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2020
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
Trott
Trott reviewed Jan 30, 2020
View reviewed changes
Comment threadCOLLABORATOR_GUIDE.md Outdated
Trott
Trott approved these changes Jan 30, 2020
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without the little nits I left. Thanks for doing this!

ronagand others added 2 commits January 30, 2020 08:29
@ronag@Trott
Update COLLABORATOR_GUIDE.md
e044298
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@ronag@Trott
Apply suggestions from code review
4c9502b
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@ronag

ronag commented Jan 30, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Landed in 1d95111

@ronagronag closed this Jan 30, 2020
ronag added a commit that referenced this pull request Jan 30, 2020
@ronag
doc: update collaborator guide citgm instructions
1d95111
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@ronag@codebytere
doc: update collaborator guide citgm instructions
e2b3e4e
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@ronag@codebytere
doc: update collaborator guide citgm instructions
a404806
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@ronag@codebytere
doc: update collaborator guide citgm instructions
173376e
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@ronag@codebytere
doc: update collaborator guide citgm instructions
5286ccc
PR-URL: #31549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ronag@richardlau@jasnell@Trott@addaleax@lpinca@BethGriggs@nodejs-github-bot