Skip to content

benchmark: use let instead of var - #31592

Closed
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:refactor/benchmark
Closed

benchmark: use let instead of var#31592
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:refactor/benchmark

Conversation

@dnlup

@dnlupdnlup commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

Use let in module, napi, net, os, path, process, querystring, streams
and string_decoder.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
benchmark: use let instead of var
af8dcca
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. module Issues and PRs related to the module subsystem. net Issues and PRs related to the net subsystem. os Issues and PRs related to the os subsystem. path Issues and PRs related to the path subsystem. labels Jan 31, 2020
@Trott

Trott commented Feb 2, 2020

Copy link
Copy Markdown
Member

Assuming this gets rid of all instances of var in the benchmark directory, we should probably enable the no-var ESLint rule in benchmark/.eslintrc.yaml.

@Trott

Trott commented Feb 2, 2020

Copy link
Copy Markdown
Member

Benchmark (and, because I forgot to remove them, also pummel and internet) CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11958/

@richardlau

richardlau commented Feb 2, 2020

Copy link
Copy Markdown
Member

There's overlap between this PR and #28958.

@dnlup

dnlup commented Feb 3, 2020

Copy link
Copy Markdown
ContributorAuthor

@Trott@richardhoehn this still doesn' get rid of all the var. I could continue the removal in this PR and then add the rule if it's ok or, given the overlap with #28958, open a new PR (sorry I missed that PR).

addaleax pushed a commit that referenced this pull request Feb 13, 2020
@dnlup@addaleax
benchmark: use let instead of var
4bf888d
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax

addaleax commented Feb 13, 2020

Copy link
Copy Markdown
Member

Landed in 4bf888d

@dnlupdnlup mentioned this pull request Feb 14, 2020
Closed
2 tasks
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@dnlup@codebytere
benchmark: use let instead of var
2de085f
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@dnlup@codebytere
benchmark: use let instead of var
5bcd73f
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@dnlup@codebytere
benchmark: use let instead of var
8538494
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@dnlup@codebytere
benchmark: use let instead of var
0b75790
Use `let` in module, napi, net, os, path, process, querystring, streams
and string_decoder.
PR-URL: #31592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@antsmartianantsmartianantsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.moduleIssues and PRs related to the module subsystem.netIssues and PRs related to the net subsystem.osIssues and PRs related to the os subsystem.pathIssues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dnlup@Trott@richardlau@addaleax@jasnell@antsmartian@nodejs-github-bot