Skip to content

src: remove unused Worker::child_port_ member - #31599

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-no-child-port
Closed

src: remove unused Worker::child_port_ member#31599
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-no-child-port

Conversation

@addaleax

Copy link
Copy Markdown
Member

This fixes a compiler warning introduced in 9225939.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This fixes a compiler warning introduced in 9225939.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Feb 1, 2020
@danbev

Copy link
Copy Markdown
Contributor

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@danbevdanbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2020
danbev pushed a commit that referenced this pull request Feb 4, 2020
This fixes a compiler warning introduced in 9225939.
PR-URL: #31599
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danbev

Copy link
Copy Markdown
Contributor

Landed in 60de60a.

@danbevdanbev closed this Feb 4, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This fixes a compiler warning introduced in 9225939.
PR-URL: #31599
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
This fixes a compiler warning introduced in 9225939.
PR-URL: #31599
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This fixes a compiler warning introduced in 9225939.
PR-URL: #31599
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
This fixes a compiler warning introduced in 9225939.
PR-URL: #31599
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.workerIssues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@danbev@nodejs-github-bot@jasnell@Trott@lpinca@cjihrig@gireeshpunathil