Skip to content

doc: clarify Worker exit/message event ordering - #31642

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-event-ordering
Closed

doc: clarify Worker exit/message event ordering#31642
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-event-ordering

Conversation

@addaleax

@addaleaxaddaleax commented Feb 5, 2020

Copy link
Copy Markdown
Member

Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
doc: clarify Worker exit/message event ordering
88ee115
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.
Refs: nodejs#31637
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Feb 5, 2020
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2020
addaleax added a commit that referenced this pull request Feb 7, 2020
@addaleax
doc: clarify Worker exit/message event ordering
7df4298
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.
Refs: #31637
PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

addaleax commented Feb 7, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 7df4298

@addaleaxaddaleax closed this Feb 7, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax@codebytere
doc: clarify Worker exit/message event ordering
77ec381
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.
Refs: #31637
PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax@codebytere
doc: clarify Worker exit/message event ordering
9b0249a
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.
Refs: #31637
PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax@codebytere
doc: clarify Worker exit/message event ordering
8dfa3fe
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.
Refs: #31637
PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax@codebytere
doc: clarify Worker exit/message event ordering
28657cc
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.
Refs: #31637
PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@jasnell@cjihrig@gireeshpunathil@nodejs-github-bot