Uh oh!
There was an error while loading. Please reload this page.
test: remove arguments.callee usage - #3167
Closed
silverwind wants to merge 1 commit into
Closed
Conversation
arguments.callee is forbidden in strict mode and the fact that it's being used masked a possible error in this test.
thefourtheye
commented
Oct 3, 2015
Contributor
Change LGTM, I am okay if the CI is okay. |
silverwind
commented
Oct 3, 2015
ContributorAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/412/ For the record, this change should've been done when we turned all tests into strict mode, pretty much an oversight on my part. |
thefourtheye
commented
Oct 3, 2015
Contributor
@silverwind Mmmm yeah. But how it was not failing the builds till now? |
silverwind
commented
Oct 3, 2015
ContributorAuthor
@thefourtheye because it only errors when it reaches a failure condition. If the test passes, the strict mode warning is never reached. What we have here, is a masked error on the linked test. |
silverwind
commented
Oct 3, 2015
ContributorAuthor
FWIW: this is the only remaining use of |
targos
commented
Oct 3, 2015
Member
LGTM, failures are unrelated. |
ChALkeR
commented
Oct 3, 2015
Member
LGTM |
silverwind added a commit
that referenced
this pull request
Oct 5, 2015
arguments.callee is forbidden in strict mode and the fact that it's being used masked a possible error in this test. PR-URL: #3167 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
silverwind
commented
Oct 5, 2015
ContributorAuthor
Thanks, landed in 342c3a1. |
silverwind added a commit
that referenced
this pull request
Oct 8, 2015
arguments.callee is forbidden in strict mode and the fact that it's being used masked a possible error in this test. PR-URL: #3167 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arguments.calleeis forbidden in strict mode and the fact that it's being used masked a possible error in this test like in this case:https://ci.nodejs.org/job/node-test-binary-arm/101/RUN_SUBSET=0,nodes=pi1-raspbian-wheezy/tapTestReport/test.tap-39/