Skip to content

doc: document self-referencing a package name - #31680

Closed
giltayar wants to merge 1 commit into
nodejs:masterfrom
giltayar:self-reference-module
Closed

doc: document self-referencing a package name#31680
giltayar wants to merge 1 commit into
nodejs:masterfrom
giltayar:self-reference-module

Conversation

@giltayar

@giltayargiltayar commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

Added a section for "Self-referencing a package using its name" that documents
importing a package's own exports (this was missed when adding the feature).

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Feb 7, 2020
@giltayar
giltayarforce-pushed the self-reference-module branch from d206dcb to fb077efCompareFebruary 7, 2020 22:09
hybrist
hybrist approved these changes Feb 7, 2020
View reviewed changes

@hybristhybrist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Looks good, one thing that may be confusing.

Comment threaddoc/api/esm.md Outdated
hybrist
hybrist reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/esm.md Outdated
@hybrist

hybrist commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

/cc @nodejs/modules-active-members

MylesBorins
MylesBorins approved these changes Feb 7, 2020
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GeoffreyBooth
GeoffreyBooth reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/esm.md Outdated
Comment threaddoc/api/esm.md Outdated
Comment threaddoc/api/esm.md Outdated
@giltayar
giltayarforce-pushed the self-reference-module branch from 6d38758 to 256fe12CompareFebruary 8, 2020 00:04
GeoffreyBooth
GeoffreyBooth reviewed Feb 8, 2020
View reviewed changes
Comment threaddoc/api/esm.md Outdated
@giltayar

giltayar commented Feb 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Not sure about the protocol, and there's nothing in the guidelines about this: should I squash the commits?

@GeoffreyBooth

GeoffreyBooth commented Feb 9, 2020

Copy link
Copy Markdown
Member

Not sure about the protocol, and there's nothing in the guidelines about this: should I squash the commits?

Yes, I think this PR would be appropriate for squashing. The commit message should follow the guidelines, such as starting with module: doc:.

@giltayar
giltayarforce-pushed the self-reference-module branch from b942e48 to 0873607CompareFebruary 13, 2020 13:42
@giltayar

giltayar commented Feb 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Rebased and squashed.

GeoffreyBooth
GeoffreyBooth reviewed Feb 13, 2020
View reviewed changes
Comment threaddoc/api/esm.md Outdated
Comment threaddoc/api/esm.md Outdated
GeoffreyBooth
GeoffreyBooth reviewed Feb 13, 2020
View reviewed changes
Comment threaddoc/api/esm.md Outdated
@giltayar
doc: document self-referencing a package name
b260d06
Added a section for "Self-referencing a package using its name" that documents
importing a package's own exports (this was missed when adding the feature).
@giltayar
giltayarforce-pushed the self-reference-module branch from 302d8d6 to b260d06CompareFebruary 13, 2020 21:37
@hybristhybrist mentioned this pull request Mar 2, 2020
Closed
@hybristhybrist added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020
@hybrist

hybrist commented Mar 2, 2020

Copy link
Copy Markdown
Contributor

Sorry for losing track of this. I assume this is good to land. I plan to do it at some point this week if nobody else beats me to it.

@addaleax

addaleax commented Mar 9, 2020

Copy link
Copy Markdown
Member

Landed in 9dbe6ab

@addaleaxaddaleax closed this Mar 9, 2020
addaleax pushed a commit that referenced this pull request Mar 9, 2020
@giltayar@addaleax
doc: document self-referencing a package name
9dbe6ab
Added a section for "Self-referencing a package using its name" that
documents importing a package's own exports (this was missed when
adding the feature).
PR-URL: #31680
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@giltayar@MylesBorins
doc: document self-referencing a package name
97965f5
Added a section for "Self-referencing a package using its name" that
documents importing a package's own exports (this was missed when
adding the feature).
PR-URL: #31680
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@giltayar@codebytere
doc: document self-referencing a package name
4386332
Added a section for "Self-referencing a package using its name" that
documents importing a package's own exports (this was missed when
adding the feature).
PR-URL: #31680
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
@giltayar@codebytere
doc: document self-referencing a package name
b00bd24
Added a section for "Self-referencing a package using its name" that
documents importing a package's own exports (this was missed when
adding the feature).
PR-URL: #31680
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@giltayar@codebytere
doc: document self-referencing a package name
3f1b916
Added a section for "Self-referencing a package using its name" that
documents importing a package's own exports (this was missed when
adding the feature).
PR-URL: #31680
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hybristhybristhybrist approved these changes
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@giltayar@hybrist@GeoffreyBooth@addaleax@MylesBorins@nodejs-github-bot