Skip to content

doc,net: reword Unix domain path paragraph in net.md - #31684

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:ipc-reword
Feb 10, 2020
Merged

doc,net: reword Unix domain path paragraph in net.md#31684
Trott merged 1 commit into
nodejs:masterfrom
Trott:ipc-reword

Conversation

@Trott

@TrottTrott commented Feb 7, 2020

Copy link
Copy Markdown
Member

Reword the paragraph on Unix domain paths. Hopefully, it is a little bit
more clear and easier to read now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Feb 7, 2020
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2020
@mscdex

Copy link
Copy Markdown
Contributor

subsystem target should just be doc for doc-only changes.

Reword the paragraph on Unix domain paths. Hopefully, it is a little bit
more clear and easier to read now.
PR-URL: nodejs#31684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Trott merged commit 6f14db4 into nodejs:masterFeb 10, 2020
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in 6f14db4

@Trott
Trott deleted the ipc-reword branch February 10, 2020 01:37
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Reword the paragraph on Unix domain paths. Hopefully, it is a little bit
more clear and easier to read now.
PR-URL: #31684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Reword the paragraph on Unix domain paths. Hopefully, it is a little bit
more clear and easier to read now.
PR-URL: #31684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Reword the paragraph on Unix domain paths. Hopefully, it is a little bit
more clear and easier to read now.
PR-URL: #31684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Reword the paragraph on Unix domain paths. Hopefully, it is a little bit
more clear and easier to read now.
PR-URL: #31684
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.netIssues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@mscdex@addaleax@cjihrig@richardlau@BridgeAR@nodejs-github-bot