Skip to content

test: improve test-fs-stat-bigint - #31726

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:allowable-delta
Closed

test: improve test-fs-stat-bigint#31726
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:allowable-delta

Conversation

@Trott

@TrottTrott commented Feb 11, 2020

Copy link
Copy Markdown
Member

Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2020
@Trott
Trott marked this pull request as ready for review February 11, 2020 05:12
Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.
@TrottTrott changed the title test: fix flaky test-fs-stat-biginttest: improve test-fs-stat-bigintFeb 11, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 11, 2020
@addaleax

Copy link
Copy Markdown
Member

Landed in d565041

addaleax pushed a commit that referenced this pull request Feb 13, 2020
Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.
PR-URL: #31726
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.
PR-URL: #31726
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.
PR-URL: #31726
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.
PR-URL: #31726
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Remove magic number and measure amount of difference should be allowable
between consecutive stat() calls.
PR-URL: #31726
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Trott deleted the allowable-delta branch April 14, 2022 11:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@addaleax@BridgeAR