Skip to content

test: mark test-fs-stat-bigint flaky on FreeBSD - #31728

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:mark-flaky
Closed

test: mark test-fs-stat-bigint flaky on FreeBSD#31728
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:mark-flaky

Conversation

@Trott

@TrottTrott commented Feb 11, 2020

Copy link
Copy Markdown
Member

Refs: #31727

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2020
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 11, 2020
@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29096/

@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29101/

@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29107/

Trott added a commit to Trott/io.js that referenced this pull request Feb 14, 2020
@Trott
test: mark test-fs-stat-bigint flaky on FreeBSD
9a1c19b
Refs: nodejs#31727
PR-URL: nodejs#31728
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott closed this Feb 14, 2020
@Trott

Trott commented Feb 14, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 9a1c19b

@Trott
Trott deleted the mark-flaky branch February 14, 2020 06:21
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Trott@codebytere
test: mark test-fs-stat-bigint flaky on FreeBSD
0654e67
Refs: #31727
PR-URL: #31728
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott@codebytere
test: mark test-fs-stat-bigint flaky on FreeBSD
02bfb70
Refs: #31727
PR-URL: #31728
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott@codebytere
test: mark test-fs-stat-bigint flaky on FreeBSD
e6229c0
Refs: #31727
PR-URL: #31728
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott@codebytere
test: mark test-fs-stat-bigint flaky on FreeBSD
aa5afd0
Refs: #31727
PR-URL: #31728
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@lundibundilundibundilundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@jasnell@cjihrig@BridgeAR@lundibundi