fs: validate the input data before opening file

[ZYSzys]

Now running python tools/test.py test/parallel/test-fs-append-file in our master branch, there was a file called foobar generated, which was caused by this line:

node/test/parallel/test-fs-append-file.js

Line 143 in fb437c4

assert.rejects(fs.promises.appendFile('foobar',data),errObj);

This was because firstly we opened foobar file and then validating the input data in our fs.promise module.

So I think the more reasonable method is validating the input data first and then opening the file, to be consistent with fs module.

Refs: #31030

/cc @BridgeAR

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29068/

[BridgeAR]

Thanks, this slipped through! LGTM % comment

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29082/

[ZYSzys]

Landed in 3e9302b.

[codebytere]

@lundibundi should this be backported to v13.x? it'll need a manual if yes.

[lundibundi]

/cc @ZYSzys ^

[ZYSzys]

I think no, since this fixed the bug caused by #31030 (which is semver-major).