Uh oh!
There was an error while loading. Please reload this page.
src: improve KVStore API - #31773
Closed
lundibundi wants to merge 2 commits into
Closed
Conversation
addaleax
approved these changes
Feb 13, 2020
nodejs-github-bot
commented
Feb 13, 2020
Collaborator
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible.
lundibundiforce-pushed
the
kvstorage-improve-api
branch
from
February 13, 2020 20:04
8591a52 to
d38ed6cComparenodejs-github-bot
commented
Feb 13, 2020
Collaborator
nodejs-github-bot
commented
Feb 16, 2020
Collaborator
joyeecheung
approved these changes
Feb 17, 2020
jasnell
approved these changes
Feb 17, 2020
nodejs-github-bot
commented
Feb 27, 2020
Collaborator
addaleax pushed a commit
that referenced
this pull request
Mar 9, 2020
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: #31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Mar 9, 2020
PR-URL: #31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
commented
Mar 9, 2020
Member
Landed in e70705c...98f4429 |
MylesBorins pushed a commit
that referenced
this pull request
Mar 9, 2020
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: #31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 9, 2020
PR-URL: #31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Apr 20, 2020
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: #31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 20, 2020
PR-URL: #31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
const char*based APIs to KVStore to avoid multiple stringconversions (char -> Utf8 -> Local -> char etc.) when possible.
Unfortunately this only changes
GetandQuerymethods as others have a hard dependency onIsolateinRealEnvStoreas they need to callDateTimeConfigurationChangeNotification. Not sure how can we move forward with that.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @addaleax