src: discard tasks posted to platform TaskRunner during shutdown by addaleax · Pull Request #31853 · nodejs/node

addaleax · 2020-02-18T19:34:35Z

Following the discussion in https://chromium-review.googlesource.com/c/v8/v8/+/2061548:

src: discard tasks posted to platform TaskRunner during shutdown

Discard tasks silently that are posted when the Isolate is being
disposed.

It is not possible to avoid a race condition window between
unregistering the Isolate with the platform and disposing it
in which background tasks and the Isolate deinit steps themselves
may lead to new tasks being posted. The only sensible action
in that case is discarding the tasks.

Fixes: #31752
Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548
Refs: #31795
Refs: #30909

Revert "src: keep main-thread Isolate attached to platform during Dispose"

This reverts commit e460f8c.

It is no longer necessary after the previous commit, and restores
consistency of the call order between the main thread code,
the other call sites, and the documentation.

Refs: #31795

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: nodejs#31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: nodejs#31795 Refs: nodejs#30909

…pose" This reverts commit e460f8c. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: nodejs#31795

addaleax · 2020-02-18T20:22:29Z

After thinking about it, I think this also means that we can and should let go of the NodePlatform::DrainTasks() calls before disposing an Isolate. I’ll pursue that separately, though … no need to mix that in with a bug fix :)

nodejs-github-bot · 2020-02-23T02:29:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29291/

nodejs-github-bot · 2020-02-26T03:32:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29365/

nodejs-github-bot · 2020-03-09T12:19:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29651/

Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: #31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: #31795 Refs: #30909 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

…pose" This reverts commit e460f8c. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: #31795 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax · 2020-03-11T15:39:39Z

Landed in d7fe554...61f28fb

Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: #31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: #31795 Refs: #30909 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

…pose" This reverts commit e460f8c. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: #31795 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Discard tasks silently that are posted when the Isolate is being disposed. It is not possible to avoid a race condition window between unregistering the Isolate with the platform and disposing it in which background tasks and the Isolate deinit steps themselves may lead to new tasks being posted. The only sensible action in that case is discarding the tasks. Fixes: #31752 Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548 Refs: #31795 Refs: #30909 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos · 2020-04-22T15:28:49Z

@addaleax can this now land on v12.x or does it depend on something else?

addaleax · 2020-04-24T21:38:04Z

@targos Yes, I think this can go ahead.

…pose" This reverts commit e460f8c. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: nodejs#31795 PR-URL: nodejs#31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

…pose" This reverts commit e460f8c. It is no longer necessary after the previous commit, and restores consistency of the call order between the main thread code, the other call sites, and the documentation. Refs: #31795 PR-URL: #31853 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added 2 commits February 18, 2020 20:25

addaleax added the lts-watch-v12.x label Feb 18, 2020

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Feb 18, 2020

addaleax added v8 platform Issues and PRs related to Node's v8::Platform implementation. and removed process Issues and PRs related to the process subsystem. labels Feb 18, 2020

gahaas approved these changes Feb 19, 2020
View reviewed changes

joyeecheung approved these changes Feb 19, 2020
View reviewed changes

Comment threadsrc/node_platform.cc

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2020

addaleax closed this Mar 11, 2020

addaleax deleted the fix-31752 branch March 11, 2020 15:39

MylesBorins mentioned this pull request Mar 12, 2020
v13.11.0 proposal #32185
Merged

codebytere mentioned this pull request Mar 24, 2020
v12.16.2 proposal #32313
Merged

targos removed lts-watch-v12.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2020

targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged

Navigation Menu

Uh oh!

Uh oh!

src: discard tasks posted to platform TaskRunner during shutdown - #31853

src: discard tasks posted to platform TaskRunner during shutdown#31853
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:fix-31752

addaleax commented Feb 18, 2020

Uh oh!

addaleax commented Feb 18, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 23, 2020

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

nodejs-github-bot commented Mar 9, 2020

Uh oh!

addaleax commented Mar 11, 2020

Uh oh!

targos commented Apr 22, 2020

Uh oh!

addaleax commented Apr 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

addaleax commented Feb 18, 2020

src: discard tasks posted to platform TaskRunner during shutdown

Revert "src: keep main-thread Isolate attached to platform during Dispose"

Checklist

Uh oh!

addaleax commented Feb 18, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 23, 2020

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

nodejs-github-bot commented Mar 9, 2020

Uh oh!

addaleax commented Mar 11, 2020

Uh oh!

targos commented Apr 22, 2020

Uh oh!

addaleax commented Apr 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants