Uh oh!
There was an error while loading. Please reload this page.
doc: add note about ssh key to releases - #31856
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
MylesBorins
approved these changes
Feb 18, 2020
MylesBorins
left a comment
Contributor
There was a problem hiding this comment.
LGTM with some tiny nits (that can be ignored)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
codebytereforce-pushed
the
add-ssh-add-note
branch
from
February 19, 2020 03:41
cf97d68 to
1d98223Comparejamesgeorge007
suggested changes
Feb 19, 2020
Uh oh!
There was an error while loading. Please reload this page.
jamesgeorge007
approved these changes
Feb 19, 2020
BethGriggs
approved these changes
Feb 19, 2020
BridgeAR
approved these changes
Feb 19, 2020
jasnell
approved these changes
Feb 19, 2020
codebytere
commented
Feb 21, 2020
MemberAuthor
Landed in ae41049 |
codebytere added a commit
that referenced
this pull request
Feb 21, 2020
PR-URL: #31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere added a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere added a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a note to the final promotion stage discussing the need to ensure that your ssh key for Node.js has been properly loaded.
cc @nodejs/releasers
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes