Uh oh!
There was an error while loading. Please reload this page.
doc: add entry for AsyncHook class - #31865
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Either
| it helps associating method calls that otherwise do not appear together | |
| it helps with associating method calls that otherwise do not appear together |
or
| it helps associating method calls that otherwise do not appear together | |
| it helps associate method calls that otherwise do not appear together |
That being said – what’s a typical call stack?
There was a problem hiding this comment.
@addaleax , I used typical here to mean a representative call stack on node.js program error. As per my understanding, a representative stack is a incomplete part of an asynchronous sequence. Am I wrong?
There was a problem hiding this comment.
@HarshithaKP I’m still confused… That kind of only moves the question from “what’s a typical call stack?” to “what’s a representative call stack?”.
To be honest, I think it’s okay to drop the second sentence here. The sentence is not accurate anyway, the IDs are unique per asynchronous resource but not per asynchronous call.
Trott
commented
Feb 21, 2020
@nodejs/documentation (I'm feeling @vsemozhetbyt's absence these days. ❤️) |
90da144 to
410b6e6Comparegireeshpunathil
commented
Mar 5, 2020
addaleax
commented
Mar 11, 2020
Landed in e4a72d6 |
fixes: #31661
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes