Skip to content

src: move BaseObject subclass dtors/ctors out of node_crypto.h - #31872

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:move_baseobj_ctors
Closed

src: move BaseObject subclass dtors/ctors out of node_crypto.h#31872
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:move_baseobj_ctors

Conversation

@jasnell

@jasnelljasnell commented Feb 19, 2020

Copy link
Copy Markdown
Member

Originally landed in the QUIC repo. Separated from from the QUIC PR. There is nothing QUIC specific in this change.

Move constructor and destructors for subclasses of BaseObject
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.

Original review metadata:

 PR-URL: https://github.com/nodejs/quic/pull/220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax@jasnell
src: move BaseObject subclass dtors/ctors out of node_crypto.h
df6ca6a
Originally landed in the QUIC repo
Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.
Original review metadata:
```
PR-URL: nodejs/quic#220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
```
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Feb 19, 2020
@jasnelljasnell mentioned this pull request Feb 19, 2020
Closed
4 tasks
lundibundi
lundibundi approved these changes Feb 19, 2020
View reviewed changes
Comment threadsrc/node_crypto.cc
@nodejs-github-bot

nodejs-github-bot commented Feb 19, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29245/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2020
jasnell pushed a commit that referenced this pull request Feb 24, 2020
@addaleax@jasnell
src: move BaseObject subclass dtors/ctors out of node_crypto.h
2035e3d
Originally landed in the QUIC repo
Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.
Original review metadata:
```
PR-URL: nodejs/quic#220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
```
PR-URL: #31872
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell

jasnell commented Feb 24, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 2035e3d

@jasnelljasnell closed this Feb 24, 2020
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@addaleax@codebytere
src: move BaseObject subclass dtors/ctors out of node_crypto.h
88ccb44
Originally landed in the QUIC repo
Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.
Original review metadata:
```
PR-URL: nodejs/quic#220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
```
PR-URL: #31872
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@codebyterecodebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax@codebytere
src: move BaseObject subclass dtors/ctors out of node_crypto.h
86ee91d
Originally landed in the QUIC repo
Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.
Original review metadata:
```
PR-URL: nodejs/quic#220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
```
PR-URL: #31872
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax@codebytere
src: move BaseObject subclass dtors/ctors out of node_crypto.h
ce9df9b
Originally landed in the QUIC repo
Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.
Original review metadata:
```
PR-URL: nodejs/quic#220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
```
PR-URL: #31872
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax@codebytere
src: move BaseObject subclass dtors/ctors out of node_crypto.h
9ab4a7e
Originally landed in the QUIC repo
Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.
Original review metadata:
```
PR-URL: nodejs/quic#220
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
```
PR-URL: #31872
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+3 more reviewers
@sam-githubsam-githubsam-github approved these changes
@devnexendevnexendevnexen approved these changes
@lundibundilundibundilundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell@nodejs-github-bot@sam-github@addaleax@cjihrig@tniessen@devnexen@lundibundi