Uh oh!
There was an error while loading. Please reload this page.
lib: add debug logs to writable stream - #31937
Closed
juanarbol wants to merge 1 commit into
Closed
Conversation
YoDaMa
reviewed
Feb 27, 2020
| } | ||
| function doWrite(stream, state, writev, len, chunk, encoding, cb) { | ||
| debug('Writting'); |
There was a problem hiding this comment.
debug('Writing %o', chunk); would be more useful
| } | ||
| state.ended = true; | ||
| stream.writable = false; | ||
| debug('endWritable', state.ended); |
There was a problem hiding this comment.
the state.ended will always be true so I'm not sure how useful this log is.
rexagod
commented
Mar 13, 2020
Member
ping @juanarbol |
juanarbol
commented
Mar 13, 2020
MemberAuthor
Sorry, I'm gonna return to this soon |
YoDaMa
commented
Mar 13, 2020
@juanarbol saw your mail, got busy, forgot to respond. I can definitely take over this PR. |
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes