Uh oh!
There was an error while loading. Please reload this page.
src: move InternalCallbackScope to StartExecution - #31944
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
codebytereforce-pushed
the
move-cb-scope
branch
from
February 25, 2020 03:54
f53a34e to
fc81fd8Compareaddaleax
approved these changes
Feb 25, 2020
Qard
previously requested changes
Feb 25, 2020
Uh oh!
There was an error while loading. Please reload this page.
codebytereforce-pushed
the
move-cb-scope
branch
from
February 25, 2020 16:08
fc81fd8 to
0f14c55Comparenodejs-github-bot
commented
Feb 26, 2020
Collaborator
Qard
approved these changes
Feb 26, 2020
joyeecheung
approved these changes
Feb 26, 2020
nodejs-github-bot
commented
Feb 27, 2020
Collaborator
codebytere added a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
codebytere
commented
Feb 27, 2020
MemberAuthor
Landed in 18ddb1d |
codebytere added a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
4 tasks
puzpuzpuz pushed a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
PR-URL: nodejs#31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
puzpuzpuz pushed a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
PR-URL: nodejs#31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #30467.
As Electron embeds Node.js, when running in
ELECTRON_RUN_AS_NODEwe need to mimicNodeMainInstance::Run()as much as possible. However, the externally-facing CallbackScope does not allow for skipping async hooks. As such, in order to embed properly without async hook issues we need to exposeInternalCallbackScopevia patch, which we would rather not do.This PR thus moves that callback scope into
StartExecutionso that we can decrease our patch surface and avoid having to handle something which should reasonably be handled upstream.cc @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes