src: revamp internal field count tracking by jasnell · Pull Request #31960 · nodejs/node

jasnell · 2020-02-26T02:48:03Z

Improved handling of internal field counts.

In a separate PR, it would likely be good to switch to use of utility functions that include DCHECKs for the InternalFieldCount().

/cc @bnoordhuis @addaleax

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2020-02-26T03:33:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29366/

bnoordhuis

Thanks, this is already much better than the current state of things and looks like it already exposes a few infidelities and at least one outright bug.

nodejs-github-bot · 2020-02-26T20:25:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29391/

nodejs-github-bot · 2020-02-26T22:59:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29397/

bnoordhuis

Thanks, LGTM with suggestions.

mcollina

lgtm

nodejs-github-bot · 2020-02-29T01:35:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29450/

Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2020-02-29T01:47:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29453/

nodejs-github-bot · 2020-03-02T16:25:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29487/

Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

jasnell · 2020-03-02T18:59:21Z

Landed in 0fac393

Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos · 2020-04-20T19:45:59Z

Depends at least on #31569 to land on v12.x

Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 26, 2020

jasnell mentioned this pull request Feb 26, 2020
dgram: make UDPWrap more reusable #31871
Closed
2 tasks

addaleax reviewed Feb 26, 2020
View reviewed changes

Comment threadsrc/async_wrap.cc Outdated
Comment threadsrc/base_object-inl.h Outdated
Comment threadsrc/cares_wrap.cc Outdated

jasnell force-pushed the revamp-internal-field-count-tracking branch from 39f07a2 to ec851dcCompare February 26, 2020 03:29

jasnell requested a review from addaleax February 26, 2020 03:29

addaleax approved these changes Feb 26, 2020
View reviewed changes

bnoordhuis reviewed Feb 26, 2020
View reviewed changes

Comment threadsrc/async_wrap.cc Outdated
Comment threadsrc/base_object.h Outdated
Comment threadsrc/node_object_wrap.h Outdated
Comment threadsrc/stream_base.h Outdated
Comment threadsrc/stream_base.h Outdated
Comment threadsrc/stream_wrap.cc Outdated

addaleax requested changes Feb 26, 2020
View reviewed changes

Comment threadsrc/async_wrap.cc Outdated

addaleax mentioned this pull request Feb 26, 2020
src: use symbol to store AsyncWrap resource #31745
Closed
2 tasks

jasnell requested a review from addaleax February 26, 2020 20:16

addaleax approved these changes Feb 26, 2020
View reviewed changes

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2020

jasnell requested a review from bnoordhuis February 26, 2020 23:32

fhinkel approved these changes Feb 27, 2020
View reviewed changes

bnoordhuis approved these changes Feb 28, 2020
View reviewed changes

Comment threadsrc/stream_base-inl.h Outdated
Comment threadsrc/stream_base.h Outdated
Comment threadsrc/stream_base.h Outdated

mcollina approved these changes Feb 28, 2020
View reviewed changes

src: improve handling of internal field counting
9c6e9cd
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell force-pushed the revamp-internal-field-count-tracking branch from aa26581 to 9c6e9cdCompare February 29, 2020 01:46

jasnell closed this Mar 2, 2020

MylesBorins mentioned this pull request Mar 4, 2020
v13.10.1 proposal #32099
Merged

targos added the backport-blocked-v12.x label Apr 20, 2020

targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 25, 2020

targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged

Uh oh!

Uh oh!

Conversation

jasnell commented Feb 26, 2020

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 29, 2020

Uh oh!

nodejs-github-bot commented Feb 29, 2020

Uh oh!

nodejs-github-bot commented Mar 2, 2020

Uh oh!

jasnell commented Mar 2, 2020• edited by addaleax Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jasnell commented Mar 2, 2020•
edited by addaleax
Loading