Uh oh!
There was an error while loading. Please reload this page.
util: fix for inspecting promises - #3197
Merged
Merged
Conversation
targos
commented
Oct 6, 2015
Member
@evanlucas I rebased the vee-eight-4.6 branch, you can update your PR to keep only the last commit |
evanlucasforce-pushed
the
fixpromiseinspect
branch
from
October 6, 2015 10:54
ee62c84 to
4c71044Comparebnoordhuis
commented
Oct 6, 2015
Member
LGTM |
targos
commented
Oct 6, 2015
Member
The upgrade to v8 4.6 removed ObjectIsPromise. This change utilizes v8::Value::IsPromise to verify that the argument is indeed a promise. PR-URL: nodejs#3197 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
evanlucasforce-pushed
the
fixpromiseinspect
branch
from
October 6, 2015 20:27
4c71044 to
4d13daeCompareevanlucas
commented
Oct 6, 2015
ContributorAuthor
Thanks! Landed in 4d13dae |
bnoordhuis
commented
Oct 6, 2015
Member
This is probably worth merging back into master to keep the delta small. You have my preemptive LGTM. |
evanlucas
commented
Oct 6, 2015
ContributorAuthor
Ok, should I just cherry-pick and push or is there a different way we are doing that? |
bnoordhuis
commented
Oct 6, 2015
Member
Maybe PR and run CI just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade to v8 4.6 removes
ObjectIsPromise. This change utilizesv8::Value::IsPromise to verify that the argument is indeed a promise.
R= @bnoordhuis, @targos
Ben, not sure if you had another way of doing this, so I went ahead and cherry-picked the changes from #3119. Feel free to close if you want to go a different route though.