buffer: FreeCallback should be tied to ArrayBuffer

src/node_buffer.cc

@@ -356,7 +356,7 @@ MaybeLocal<Object> New(Environment* env,
  if (!mb.FromMaybe(false))
  return Local<Object>();
 
- CallbackInfo::New(env->isolate(), ui, callback, hint);
+ CallbackInfo::New(env->isolate(), ab, callback, hint);
  return scope.Escape(ui);
 }
 

test/addons/buffer-free-callback/binding.cc

@@ -0,0 +1,36 @@
+#include <node.h>
+#include <node_buffer.h>
+#include <util.h>
+#include <v8.h>
+
+static int alive;
+static char buf[1024];
+
+static void FreeCallback(char* data, void* hint) {
+ alive--;
+}
+
+void Alloc(const v8::FunctionCallbackInfo<v8::Value>& args) {
+ v8::Isolate* isolate = args.GetIsolate();
+ alive++;
+ args.GetReturnValue().Set(node::Buffer::New(
+ isolate,
+ buf,
+ sizeof(buf),
+ FreeCallback,
+ nullptr).ToLocalChecked());
+}
+
+void Check(const v8::FunctionCallbackInfo<v8::Value>& args) {
+ v8::Isolate* isolate = args.GetIsolate();
+ isolate->RequestGarbageCollectionForTesting(
+ v8::Isolate::kFullGarbageCollection);
+ CHECK_GT(alive, 0);
+}
+
+void init(v8::Local<v8::Object> target) {
+ NODE_SET_METHOD(target, "alloc", Alloc);
+ NODE_SET_METHOD(target, "check", Check);
+}
+
+NODE_MODULE(binding, init);

test/addons/buffer-free-callback/binding.gyp

@@ -0,0 +1,8 @@
+{
+ 'targets': [
+ {
+ 'target_name': 'binding',
+ 'sources': [ 'binding.cc' ]
+ }
+ ]
+}

test/addons/buffer-free-callback/test.js

@@ -0,0 +1,9 @@
+'use strict';
+// Flags: --expose-gc
+
+varassert=require('assert');
+varbinding=require('./build/Release/binding');
+varbuf=binding.alloc();
+varslice=buf.slice(32);
+buf=null;
+binding.check(slice);