Skip to content

test: always ignore vm-timeout-escape-queuemicrotask - #31980

Closed
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:ignore-escape-queuemicrotask
Closed

test: always ignore vm-timeout-escape-queuemicrotask#31980
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:ignore-escape-queuemicrotask

Conversation

@lundibundi

@lundibundilundibundi commented Feb 27, 2020

Copy link
Copy Markdown
Member

Always skip the test as it is not expected to be fixed (probably ever).
Left in the known_issues as an example and 'note' that the issue is
there and won't be fixed.

Follow up #31966.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 27, 2020
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29413/

jasnell
jasnell reviewed Feb 27, 2020
View reviewed changes
Comment threadtest/known_issues/test-vm-timeout-escape-queuemicrotask.js Outdated
addaleax
addaleax reviewed Feb 27, 2020
View reviewed changes
Comment threadtest/known_issues/test-vm-timeout-escape-queuemicrotask.js Outdated
@addaleaxaddaleax mentioned this pull request Mar 2, 2020
Closed
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29489/

@mmarchinimmarchini mentioned this pull request Mar 2, 2020
Closed
2 tasks
@mmarchini

mmarchini commented Mar 2, 2020

Copy link
Copy Markdown
Contributor

Our CI is treating the skipped test as failing?

09:08:25 not ok 2833 known_issues/test-vm-timeout-escape-queuemicrotask
09:08:25 ---
09:08:25 duration_ms: 0.154
09:08:25 severity: fail
09:08:25 stack: |-
09:08:25 1..0 # Skipped: This issue is unfixable with the current implementations of V8 and Node.js. Changes to make this fixable are unlikely to happen in the foreseeable future. The test itself is flaky and skipped. It serves as a demonstration of the issue only.

@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020
@richardlau

richardlau commented Mar 3, 2020

Copy link
Copy Markdown
Member

Our CI is treating the skipped test as failing?

known_issues tests are expected to fail (unless specified otherwise in the status file).

@lundibundi
test: always skip vm-timeout-escape-queuemicrotask
4629d51
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped. It
serves as a demonstration of the issue only.
@lundibundi
lundibundiforce-pushed the ignore-escape-queuemicrotask branch from e13248c to 4629d51CompareMarch 4, 2020 15:53
@lundibundi

lundibundi commented Mar 4, 2020

Copy link
Copy Markdown
MemberAuthor

@mmarchini@richardlau@jasnell@lpinca PTAL, removed the skip from the test and put to in the .status file instead.

@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29537/

@jasnell

jasnell commented Mar 4, 2020

Copy link
Copy Markdown
Member

Still LGTM

@nodejs-github-bot

nodejs-github-bot commented Mar 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29595/

@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29671/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29678/

@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29680/

@nodejs-github-bot

nodejs-github-bot commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29698/

@mmarchini

mmarchini commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Landed in 30bbeb7

mmarchini pushed a commit that referenced this pull request Mar 10, 2020
@lundibundi@mmarchini
test: always skip vm-timeout-escape-queuemicrotask
30bbeb7
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped. It
serves as a demonstration of the issue only.
PR-URL: #31980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 10, 2020
@lundibundi@MylesBorins
test: always skip vm-timeout-escape-queuemicrotask
4589863
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped. It
serves as a demonstration of the issue only.
PR-URL: #31980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
@lundibundi@codebytere
test: always skip vm-timeout-escape-queuemicrotask
5d30570
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped. It
serves as a demonstration of the issue only.
PR-URL: #31980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebyterecodebytere mentioned this pull request Mar 24, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@lundibundi@codebytere
test: always skip vm-timeout-escape-queuemicrotask
f79da74
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped. It
serves as a demonstration of the issue only.
PR-URL: #31980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Mar 31, 2020
@lundibundi@codebytere
test: always skip vm-timeout-escape-queuemicrotask
7123c0f
This issue is unfixable with the current implementations of V8 and
Node.js. Changes to make this fixable are unlikely to happen in the
foreseeable future. The test itself is flaky and skipped. It
serves as a demonstration of the issue only.
PR-URL: #31980
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@addaleaxaddaleaxaddaleax left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@lundibundi@nodejs-github-bot@mmarchini@richardlau@jasnell@Trott@addaleax@lpinca@BridgeAR