Uh oh!
There was an error while loading. Please reload this page.
meta: move maclover7 to Emeritus - #31994
Merged
Merged
Conversation
Trott
commented
Feb 28, 2020
MemberAuthor
MylesBorins
approved these changes
Feb 28, 2020
MylesBorins
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks for the hard work!
gireeshpunathil
approved these changes
Feb 28, 2020
mmarchini
approved these changes
Feb 28, 2020
cjihrig
approved these changes
Feb 28, 2020
BridgeAR
approved these changes
Feb 28, 2020
lpinca
approved these changes
Feb 28, 2020
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: nodejs#31994 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Mar 1, 2020
MemberAuthor
Landed in ed16746 |
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 3, 2020
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Mar 15, 2020
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Mar 17, 2020
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 30, 2020
In email, maclover7 confirmed that are fine to move to emeritus status. PR-URL: #31994 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In email, maclover7 confirmed that are fine to move to emeritus status.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes