Skip to content

test: add GC test for disabled AsyncLocalStorage - #31995

Closed
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:async-storage-gcable-test
Closed

test: add GC test for disabled AsyncLocalStorage#31995
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:async-storage-gcable-test

Conversation

@puzpuzpuz

@puzpuzpuzpuzpuzpuz commented Feb 28, 2020

Copy link
Copy Markdown
Member

Adds a GC test for AsyncLocalStorage to verify behavior described in the docs.

cc @vdeturckheim@Qard@Flarna

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Feb 28, 2020
@addaleax

addaleax commented Feb 28, 2020

Copy link
Copy Markdown
Member

Fast-track? It adds a relatively straightforward new test.

@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 28, 2020
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29427/

@puzpuzpuz

puzpuzpuz commented Feb 28, 2020

Copy link
Copy Markdown
MemberAuthor

Looks like tests are flaky. As far as I can see, failed tests are not related with this PR.

@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29469/

@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
MemberAuthor

Another flaky CI run 😢. Could someone re-run it?

@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29477/

@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29481/

@puzpuzpuz
puzpuzpuzforce-pushed the async-storage-gcable-test branch from 8756024 to e4f1c18CompareMarch 2, 2020 14:12
@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
MemberAuthor

I have rebased over the latest master. Maybe those flaky tests are fixed and it would help CI build to pass.

@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29484/

@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
MemberAuthor

Another flaky CI run here.

@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29493/

@puzpuzpuz

puzpuzpuz commented Mar 2, 2020

Copy link
Copy Markdown
MemberAuthor

Looks like this one is ready to land.

mhdawson
mhdawson approved these changes Mar 2, 2020
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Mar 2, 2020

Copy link
Copy Markdown
Member

Landing now

mhdawson pushed a commit that referenced this pull request Mar 2, 2020
@puzpuzpuz@mhdawson
test: add GC test for disabled AsyncLocalStorage
96e70c4
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson

mhdawson commented Mar 2, 2020

Copy link
Copy Markdown
Member

Landed as 96e70c4

@mhdawsonmhdawson closed this Mar 2, 2020
@puzpuzpuz
puzpuzpuz deleted the async-storage-gcable-test branch March 3, 2020 08:34
MylesBorins pushed a commit that referenced this pull request Mar 4, 2020
@puzpuzpuz@MylesBorins
test: add GC test for disabled AsyncLocalStorage
1539928
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 4, 2020
Merged
@codebytere

codebytere commented Mar 16, 2020

Copy link
Copy Markdown
Member

Blocked on #26540.

@puzpuzpuzpuzpuzpuz mentioned this pull request Mar 17, 2020
Closed
4 tasks
@puzpuzpuz

puzpuzpuz commented Mar 17, 2020

Copy link
Copy Markdown
MemberAuthor

v12 backport: #32318

puzpuzpuz added a commit to puzpuzpuz/node that referenced this pull request Apr 14, 2020
@puzpuzpuz
test: add GC test for disabled AsyncLocalStorage
ecc5935
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targostargos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@puzpuzpuz@targos
test: add GC test for disabled AsyncLocalStorage
c759d65
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@puzpuzpuz@targos
test: add GC test for disabled AsyncLocalStorage
52a1154
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targostargos mentioned this pull request May 2, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@FlarnaFlarnaFlarna approved these changes
+2 more reviewers
@vdeturckheimvdeturckheimvdeturckheim approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@puzpuzpuz@addaleax@nodejs-github-bot@mhdawson@codebytere@Qard@jasnell@gireeshpunathil@vdeturckheim@Flarna@targos