Uh oh!
There was an error while loading. Please reload this page.
docs: replace all instances of node.js with io.js because trademark. - #32
docs: replace all instances of node.js with io.js because trademark.#32mikeal wants to merge 1 commit into
Conversation
rvagg
commented
Dec 3, 2014
Can we get rid of the "Evented I/O For V8 JavaScript" garbage while we're in there too? |
mikeal
commented
Dec 3, 2014
@rvagg that's already gone in the README, where else is it? |
SomeoneWeird
commented
Dec 3, 2014
Do we need to s/nodejs/iojs/g too? Or only remove references to "node.js"? Not really across trademark laws. |
rvagg
commented
Dec 3, 2014
@SomeoneWeird are there instances where it makes sense to do this? We should be thorough in this unless it's too yak-shavy. @mikeal see src/res/node.rc - on current joyent/node it even shows up on the Windows process manager as "Evented I/O for V8 JavaScript" with no mention of "node", we have it fixed here and you're changing it to "io.js: Evented I/O for V8 JavaScript". I don't know what else to call it but anything would be better than that. |
ef69bad to
e36faf4Comparervagg
commented
Dec 4, 2014
this reaches down in to npm to make changes and probably shouldn't |
d7e65ff to
185d11cCompareSomeoneWeird
commented
Dec 4, 2014
Yeah, I think ./deps should be ignored, doesn't really make a whole lot of sense. |
There was a problem hiding this comment.
This should be reverted, it checks if the debugged file is src/node.js.
bnoordhuis
commented
Dec 4, 2014
Okay, I'll stop repeating myself. :-) All changes to deps/ and some of the changes to src/ and test/ should be reverted. Run |
mikeal
commented
Dec 4, 2014
I'm closing this, it doesn't merge cleanly and is rife with problems. |
I doubt this is acceptable "as is" but it's a good starting point to talk about all the places the trademarked term "node.js" appears in the repo and what, in all, might need to be changed in order to remove it.