Skip to content

test: use index.js if package.json "main" is empty - #32040

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:empty-main
Closed

test: use index.js if package.json "main" is empty#32040
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:empty-main

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented Mar 2, 2020

Copy link
Copy Markdown
Member

Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.

Refs: #32013

@bnoordhuis
test: use index.js if package.json "main" is empty
3704db3
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.
Refs: nodejs#32013
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 2, 2020
@bnoordhuisbnoordhuis mentioned this pull request Mar 2, 2020
Closed
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29491/

@lundibundilundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020
addaleax pushed a commit that referenced this pull request Mar 9, 2020
@bnoordhuis@addaleax
test: use index.js if package.json "main" is empty
8ce6315
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.
Refs: #32013
PR-URL: #32040
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax

addaleax commented Mar 9, 2020

Copy link
Copy Markdown
Member

Landed in 8ce6315

@addaleaxaddaleax closed this Mar 9, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@bnoordhuis@MylesBorins
test: use index.js if package.json "main" is empty
862cd2b
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.
Refs: #32013
PR-URL: #32040
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@bnoordhuis@codebytere
test: use index.js if package.json "main" is empty
fa8d736
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.
Refs: #32013
PR-URL: #32040
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 23, 2020
@bnoordhuis@codebytere
test: use index.js if package.json "main" is empty
bd09a75
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.
Refs: #32013
PR-URL: #32040
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@bnoordhuis@codebytere
test: use index.js if package.json "main" is empty
1470457
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.
Refs: #32013
PR-URL: #32040
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@lundibundilundibundilundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bnoordhuis@nodejs-github-bot@addaleax@jasnell@lpinca@cjihrig@richardlau@lundibundi