Uh oh!
There was an error while loading. Please reload this page.
doc: change worker.takeHeapSnapshot to getHeapSnapshot - #32061
Closed
Flarna wants to merge 2 commits into
Closed
Conversation
9 tasks
addaleax
approved these changes
Mar 3, 2020
cjihrig
approved these changes
Mar 3, 2020
codebytere
approved these changes
Mar 3, 2020
Trott
commented
Mar 3, 2020
Member
Nit: To maintain alphabetical order, the entry will need to be moved from its current location to above |
mmarchini
approved these changes
Mar 3, 2020
Flarna
commented
Mar 3, 2020
MemberAuthor
moved. |
jasnell
approved these changes
Mar 3, 2020
lpinca
approved these changes
Mar 3, 2020
Trott
approved these changes
Mar 3, 2020
legendecas
commented
Mar 4, 2020
Member
Is it worth to mention that this API doesn't share an identical signature with |
BridgeAR
approved these changes
Mar 9, 2020
Adapt doc to match implementation which exports getHeapSnapshot().
Flarnaforce-pushed
the
doc_worker_getheadsnapshot
branch
from
March 10, 2020 07:53
9a60ad5 to
4a9b8ccCompareFlarna
commented
Mar 10, 2020
MemberAuthor
rebased, hopefully ASAN build is now green. |
mmarchini pushed a commit
that referenced
this pull request
Mar 10, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: #32061 Refs: #31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
mmarchini
commented
Mar 10, 2020
Contributor
Landed in 28fae8b |
MylesBorins pushed a commit
that referenced
this pull request
Mar 10, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: #32061 Refs: #31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: nodejs#32061 Refs: nodejs#31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Adapt doc to match implementation which exports getHeapSnapshot(). PR-URL: #32061 Refs: #31569 Refs: https://github.com/nodejs/node/blob/987a67339518d0380177a2e589f2bbd274230d0e/lib/internal/worker.js#L323 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt doc to match implementation which exports getHeapSnapshot().
Refs: #31569
Refs:
node/lib/internal/worker.js
Line 323 in 987a673
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes