Uh oh!
There was an error while loading. Please reload this page.
src: introduce node_sockaddr - #32070
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
devnexen
approved these changes
Mar 3, 2020
richardlau
approved these changes
Mar 3, 2020
nodejs-github-bot
commented
Mar 3, 2020
Collaborator
addaleax
approved these changes
Mar 3, 2020
nodejs-github-bot
commented
Mar 4, 2020
Collaborator
jasnell
commented
Mar 4, 2020
MemberAuthor
Relevant build failure on macos... hopefully fixed up.. trying again |
nodejs-github-bot
commented
Mar 4, 2020
Collaborator
jasnell
commented
Mar 4, 2020
MemberAuthor
this is ready to go as soon as the 48 hours is up :-) |
lundibundi
approved these changes
Mar 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell added a commit
that referenced
this pull request
Mar 5, 2020
Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32070 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
jasnell
commented
Mar 5, 2020
MemberAuthor
Landed in ba462c2 |
MylesBorins pushed a commit
that referenced
this pull request
Mar 9, 2020
Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32070 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
targos
commented
Apr 20, 2020
Member
Depends on #31871 to land on v12.x |
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#32070 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32070 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the QUIC PR to allow for more incremental review.
Introduce the SocketAddress utility class. While not specific to QUIC, the QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core
Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes