Uh oh!
There was an error while loading. Please reload this page.
doc: clear up child_process command resolution - #32091
Closed
lundibundi wants to merge 3 commits into
Closed
Conversation
addaleax
reviewed
Mar 4, 2020
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Anna Henningsen <github@addaleax.net>
Uh oh!
There was an error while loading. Please reload this page.
richardlau
approved these changes
Mar 4, 2020
bzoz
approved these changes
Mar 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
lpinca
approved these changes
Mar 5, 2020
BridgeAR
approved these changes
Mar 9, 2020
addaleax
commented
Mar 11, 2020
Member
Landed in 4b84010 |
addaleax pushed a commit
that referenced
this pull request
Mar 11, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
Mar 11, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
Mar 11, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos pushed a commit
that referenced
this pull request
Apr 22, 2020
Fixes: #20605 Refs: libuv/libuv#1837 PR-URL: #32091 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #20605
Refs: libuv/libuv#1837
/cc @richardlau @nodejs/platform-windows @nodejs/documentation @nodejs/child_process
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes