Uh oh!
There was an error while loading. Please reload this page.
src: add missing namespace using statements in node_watchdog.h - #32117
Closed
legendecas wants to merge 1 commit into
Closed
src: add missing namespace using statements in node_watchdog.h#32117legendecas wants to merge 1 commit into
legendecas wants to merge 1 commit into
Conversation
Although these `using`s can derived from other header files, it will be better to be self-contained.
cjihrig
approved these changes
Mar 6, 2020
jasnell
approved these changes
Mar 6, 2020
devnexen
approved these changes
Mar 6, 2020
richardlau
approved these changes
Mar 6, 2020
nodejs-github-bot
commented
Mar 6, 2020
Collaborator
addaleax
approved these changes
Mar 6, 2020
addaleax pushed a commit
that referenced
this pull request
Mar 9, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: #32117 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
commented
Mar 9, 2020
Member
Landed in e70705c |
MylesBorins pushed a commit
that referenced
this pull request
Mar 9, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: #32117 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
targos
commented
Apr 20, 2020
Member
Depends on #29207 to land on v12.x |
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: nodejs#32117 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: #32117 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although these
usings can derived from other header files, it willbe better to be self-contained.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes