Skip to content

test: buffer.write with longer string scenario - #32123

Closed
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:assert_buffer.write_string
Closed

test: buffer.write with longer string scenario#32123
HarshithaKP wants to merge 2 commits into
nodejs:masterfrom
HarshithaKP:assert_buffer.write_string

Conversation

@HarshithaKP

@HarshithaKPHarshithaKP commented Mar 6, 2020

Copy link
Copy Markdown
Member

Make sure longer strings are written up to the buffer end

Refs: #32119

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@HarshithaKP
test: buffer.write with longer string scenario
2fdbb5e
Make sure longer strings are written up to the buffer end
Refs: nodejs#32119
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 6, 2020
addaleax
addaleax approved these changes Mar 7, 2020
View reviewed changes
Comment threadtest/parallel/test-buffer-write.js
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29656/

@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29751/

@addaleax

addaleax commented Mar 12, 2020

Copy link
Copy Markdown
Member

Landed in 7fcb8da

addaleax pushed a commit that referenced this pull request Mar 12, 2020
@HarshithaKP@addaleax
test: buffer.write with longer string scenario
7fcb8da
Make sure longer strings are written up to the buffer end
Refs: #32119
PR-URL: #32123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
@HarshithaKP@BridgeAR
test: buffer.write with longer string scenario
0dd6e4a
Make sure longer strings are written up to the buffer end
Refs: #32119
PR-URL: #32123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@HarshithaKP@MylesBorins
test: buffer.write with longer string scenario
08edf53
Make sure longer strings are written up to the buffer end
Refs: #32119
PR-URL: #32123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Apr 22, 2020
@HarshithaKP@targos
test: buffer.write with longer string scenario
914eddd
Make sure longer strings are written up to the buffer end
Refs: #32119
PR-URL: #32123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Apr 22, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@HarshithaKP@nodejs-github-bot@addaleax@jasnell@cjihrig@BridgeAR