Uh oh!
There was an error while loading. Please reload this page.
doc: remove personal pronouns in reference docs prose - #32142
Closed
Trott wants to merge 0 commit into
Closed
Conversation
tniessen
approved these changes
Mar 9, 2020
BridgeAR
approved these changes
Mar 9, 2020
trivikr
approved these changes
Mar 9, 2020
Trott
commented
Mar 10, 2020
MemberAuthor
Landed in 66e32ff...73f2dbc |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 10, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: nodejs#32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 28, 2020
Per our style guide, avoid personal pronouns (I, you, we, etc.) in reference documentation. PR-URL: #32142 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per style guide, avoid personal pronouns in reference docs, hopefully without introducing a ton of passive voice.
Lint rule is possible, but I personally want to take some time to make sure this isn't a guideline we want to keep. For now, though, abide by it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes