Uh oh!
There was an error while loading. Please reload this page.
meta: move inactive collaborators to emeriti - #32151
Merged
Merged
Conversation
tniessen
approved these changes
Mar 9, 2020
trivikr
approved these changes
Mar 9, 2020
Trott
commented
Mar 10, 2020
MemberAuthor
@nodejs/tsc |
rubys
commented
Mar 10, 2020
Member
I wish to remain a collaborator. |
jasnell
approved these changes
Mar 11, 2020
tniessen
approved these changes
Mar 11, 2020
hiroppy
approved these changes
Mar 11, 2020
Trott
commented
Mar 11, 2020
MemberAuthor
@seishun sent me an email saying they want to remain a collaborator, so I'll update this.... |
Trott
commented
Mar 12, 2020
MemberAuthor
Restored @seishun. This should be ready to land. One more approval or re-approval for good measure would be great. |
MylesBorins
approved these changes
Mar 12, 2020
MylesBorins
left a comment
Contributor
There was a problem hiding this comment.
LGTM
so long and thanks for all the commits
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#32151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Trott
commented
Mar 12, 2020
MemberAuthor
Landed in e6a55b4 |
BridgeAR pushed a commit
that referenced
this pull request
Mar 17, 2020
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 24, 2020
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 22, 2020
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sent an email to inactive collaborators (in the previous 6 months at
the time, no commits, no PRs reviewed, and no commits landed) asking if
it was time to move to emeritus.
Some replied affirmatively and I have moved those people to emeritus.
Others replied indicating a desire to remain collaborators, and I left
them as collaborators.
The remaining folks are being moved to emeritus in this change.
@claudiorodriguez@iarna@italoacasas@MoonBall@rubys@seishun@trevnorris If any of you wish to remain collaborators for any reason whatsoever, just let me know in the next 72 hours and I'll remove you from this PR. (You don't even have to tell me what the reason is. Leave a comment here or send me an email.)
Thanks for all the great contributions and collaboration over the years!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes